Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Error message not showing watchlog for scope. #258

Closed
irfantusneem opened this issue Nov 10, 2013 · 1 comment
Closed

Error message not showing watchlog for scope. #258

irfantusneem opened this issue Nov 10, 2013 · 1 comment
Milestone

Comments

@irfantusneem
Copy link

The watchLog is currently broken, it used to show you the last values, but now it's always empty:
https://github.com/angular/angular.dart/blob/master/lib/core/scope.dart#L347

I added the following code in scope.dart to track the issue. is it possible add this sort of debugging support on a permanent basis or fix the watch log. It helps pinpoint the problem a lot faster.

            if (!_identical(value, last)) {
              if (_ttlLeft == 1)
                print('value = $value  last = $last');
              dirty = true;
              watch.last = value;
@mhevery
Copy link
Contributor

mhevery commented Nov 19, 2013

The watch log code was removed because in Dart closure.toString() does not return anything useful. Not sure when we will have a good fix for that.

@ghost ghost assigned pavelgj Dec 9, 2013
pavelgj added a commit to pavelgj/angular.dart that referenced this issue Dec 14, 2013
pavelgj added a commit to pavelgj/angular.dart that referenced this issue Dec 14, 2013
pavelgj added a commit to pavelgj/angular.dart that referenced this issue Dec 14, 2013
pavelgj added a commit to pavelgj/angular.dart that referenced this issue Dec 14, 2013
pavelgj added a commit to pavelgj/angular.dart that referenced this issue Dec 14, 2013
pavelgj added a commit that referenced this issue Dec 14, 2013
Closes #258

Conflicts:
	lib/core/scope.dart
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants