This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
fix(components): the content tag duplicates elements #1422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsavkin
force-pushed
the
fix_content_tag_duplicates_elements
branch
from
3e6f590 to
4a56302
Compare
|
@mhevery can you review it? It fixes a rather serious bug, so I'd like to get it into master asap. |
chirayuk
force-pushed
the
master
branch
2 times, most recently
from
8fd235c to
50e2645
Compare
vsavkin
force-pushed
the
fix_content_tag_duplicates_elements
branch
from
4a56302 to
b7b18fa
Compare
vsavkin
added a commit
to vsavkin/angular.dart
that referenced
this pull request
Sep 9, 2014
vsavkin
added a commit
that referenced
this pull request
Sep 11, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the component factory to pull light DOM elements before they get compiled. It is important when the light dom has viewport nodes, because they change their siblings.