This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 248
fix(TestBed): TestBed toNodeList and whitespace #1262
Comments
jbdeboer
pushed a commit
to jbdeboer/angular.dart
that referenced
this issue
Aug 29, 2014
Add whitespace handling to the TestBed’s compile function. Closes dart-archive#1262. Previously, strings passed with leading or trailing whitespace would be compiled incorrectly. Now, valid HTML with arbitrary whitespace in and surrounding it can be compiled properly. Closes dart-archive#1346
jbdeboer
pushed a commit
to jbdeboer/angular.dart
that referenced
this issue
Sep 11, 2014
Add whitespace handling to the TestBed’s compile function. Closes dart-archive#1262. Previously, strings passed with leading or trailing whitespace would be compiled incorrectly. Now, valid HTML with arbitrary whitespace in and surrounding it can be compiled properly. Closes dart-archive#1346
jbdeboer
pushed a commit
to jbdeboer/angular.dart
that referenced
this issue
Sep 11, 2014
Add whitespace handling to the TestBed’s compile function. Closes dart-archive#1262. Previously, strings passed with leading or trailing whitespace would be compiled incorrectly. Now, valid HTML with arbitrary whitespace in and surrounding it can be compiled properly. Closes dart-archive#1346
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I was using the
TestBed
class and found that therootElement
member wasn't being set properly. After some searching, I found that the problem was with thetoNodeList
function and the string I was passing to theTestBed
's compile function:The node list returned by
toNodeList
looked something like thisIt looks like
toNodeList
doesn't play well with whitespace. I got around it by just trimming the string first, but I don't know if that could introduce any other issues down the line.The text was updated successfully, but these errors were encountered: