fix(compiler): don't create watchers for attr mappings if no attr is …

…specified Closes #265
dart-archive · Nov 15, 2013 · eb6ba0d · eb6ba0d
1 parent 75a0f3d
commit eb6ba0d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/core_dom/compiler.dart b/lib/core_dom/compiler.dart
@@ -151,6 +151,7 @@ class Compiler {
           break;
         case '<=>':
           mappingFn = (NodeAttrs attrs, Scope scope, Object dst) {
+            if (attrs[attrName] == null) return;
             Expression attrExprFn = _parser(attrs[attrName]);
             var shadowValue = null;
             scope.$watch(
@@ -172,6 +173,7 @@ class Compiler {
           break;
         case '=>':
           mappingFn = (NodeAttrs attrs, Scope scope, Object dst) {
+            if (attrs[attrName] == null) return;
             Expression attrExprFn = _parser(attrs[attrName]);
             var shadowValue = null;
             scope.$watch(
@@ -182,6 +184,7 @@ class Compiler {
           break;
         case '=>!':
           mappingFn = (NodeAttrs attrs, Scope scope, Object dst) {
+            if (attrs[attrName] == null) return;
             Expression attrExprFn = _parser(attrs[attrName]);
             var stopWatching;
             stopWatching = scope.$watch(

diff --git a/test/core_dom/compiler_spec.dart b/test/core_dom/compiler_spec.dart
@@ -244,6 +244,14 @@ main() => describe('dte.compiler', () {
         expect($rootScope.done).toEqual(true);
       })));
 
+      it('should should not create any watchers if no attributes are specified', async(inject((Profiler perf) {
+        var element = $(r'<div><io></io></div>');
+        $compile(element)(injector, element);
+        microLeap();
+        injector.get(Scope).$digest();
+        expect(perf.counters['ng.scope.watchers']).toEqual(0);
+      })));
+
       it('should create a component with I/O and "=" binding value should be available', async(inject(() {
         $rootScope.name = 'misko';
         var element = $(r'<div><io attr="A" expr="name" ondone="done=true"></io></div>');