fix(symbol_inspector): Do not return private symbols

dart-archive · Apr 18, 2014 · a66b2c1 · a66b2c1
1 parent 8c05db6
commit a66b2c1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/tools/symbol_inspector/symbol_inspector.dart b/lib/tools/symbol_inspector/symbol_inspector.dart
@@ -25,6 +25,7 @@ Iterable<Symbol> _getUsedSymbols(DeclarationMirror decl, seenDecls, path, onlyTy
   seenDecls[decl.qualifiedName] = true;
 
   if (decl.isPrivate) return [];
+
   path = "$path -> $decl";
 
   var used = [];
@@ -97,6 +98,11 @@ getSymbolsFromLibrary(String libraryName) {
     if (SHOULD_PRINT_SYMBOL_TREE) print(printPrefix + unwrapSymbol(lib.qualifiedName));
     printPrefix += "  ";
     lib.declarations.forEach((symbol, decl) {
+      if (decl.isPrivate) return;
+
+      // Work-around for dartbug.com/18271
+      if (decl is TypedefMirror && unwrapSymbol(symbol).startsWith('_')) return;
+
       if (SHOULD_PRINT_SYMBOL_TREE) print(printPrefix + unwrapSymbol(symbol));
       names.add(new QualifiedSymbol(symbol, decl.qualifiedName, lib.qualifiedName));
       used[decl.qualifiedName] = _getUsedSymbols(decl, {}, "", false);

diff --git a/test/tools/symbol_inspector/simple_library.dart b/test/tools/symbol_inspector/simple_library.dart
@@ -15,6 +15,9 @@ class A {
   static StaticFieldType staticField = null;
 }
 
+class _PrivateClass {} // Should not be exported.
+typedef _PrivateTypedef(int a); // Also should not be exported.
+
 typedef TypedefReturnType TypedefType(TypedefParam a);
 
 class ConsParamType {}