fix(block_factory): should not call attach when scope is destroyed

dart-archive · Feb 21, 2014 · 72708e3 · 72708e3
1 parent 484f03d
commit 72708e3
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/lib/core_dom/block_factory.dart b/lib/core_dom/block_factory.dart
@@ -204,7 +204,9 @@ class BlockFactory {
         checkAttachReady() {
           if (attachDelayStatus.reduce((a, b) => a && b)) {
             attachDelayStatus = null;
-            controller.attach();
+            if (scope.isAttached) {
+              controller.attach();
+            }
           }
         }
         for(var map in ref.mappings) {

diff --git a/test/core_dom/compiler_spec.dart b/test/core_dom/compiler_spec.dart
@@ -176,6 +176,7 @@ main() => describe('dte.compiler', () {
         module.type(PublishMeDirective);
         module.type(LogComponent);
         module.type(AttachDetachComponent);
+        module.type(SimpleAttachComponent);
         module.type(SimpleComponent);
         module.type(ExprAttrComponent);
         module.type(SayHelloFilter);
@@ -482,6 +483,18 @@ main() => describe('dte.compiler', () {
           expect(logger).toEqual(['detach']);
           expect(element.textWithShadow()).toEqual('WORKED');
         })));
+
+        it('should should not call attach after scope is destroyed', async(inject((Logger logger) {
+          var element = $('<simple-attach></simple-attach>');
+          var scope = rootScope.createChild({});
+          $compile(element, directives)(injector.createChild([new Module()..value(Scope, scope)]), element);
+          expect(logger).toEqual(['SimpleAttachComponent']);
+          scope.destroy();
+
+          rootScope.apply();
+
+          expect(logger).toEqual(['SimpleAttachComponent']);
+        })));
       });
 
       describe('invalid components', () {
@@ -844,3 +857,11 @@ class ExprAttrComponent {
   }
 }
 
+@NgComponent(selector: 'simple-attach')
+class SimpleAttachComponent implements NgAttachAware {
+  Logger logger;
+  SimpleAttachComponent(this.logger) {
+    logger('SimpleAttachComponent');
+  }
+  attach() => logger('attach');
+}