feat(metadata extractor): Cache the fieldMetadataExtractor for greate…

…r performance Dartium tests run in 7.6s; down from 18.2s. dart2js on Chrome runs in 2m instead of 3m
dart-archive · Apr 1, 2014 · 63c229c · vicb · Apr 1, 2014 · 63c229c
1 parent 2f186e4
commit 63c229c
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/lib/core/registry_dynamic.dart b/lib/core/registry_dynamic.dart
@@ -3,6 +3,8 @@ library angular.core_dynamic;
 import 'dart:mirrors';
 import 'package:angular/core/module_internal.dart';
 
+var _fieldMetadataCache = new Map<Type, Map<String, AttrFieldAnnotation>>();
+
 class DynamicMetadataExtractor implements MetadataExtractor {
   final _fieldAnnotations = [
         reflectType(NgAttr),
@@ -51,6 +53,10 @@ class DynamicMetadataExtractor implements MetadataExtractor {
 
 
   Map<String, AttrFieldAnnotation> fieldMetadataExtractor(Type type) {
+    return _fieldMetadataCache.putIfAbsent(type, () => _fieldMetadataExtractor(type));
+  }
+
+  Map<String, AttrFieldAnnotation> _fieldMetadataExtractor(Type type) {
     ClassMirror cm = reflectType(type);
     final fields = <String, AttrFieldAnnotation>{};
     cm.declarations.forEach((Symbol name, DeclarationMirror decl) {