fix(MetadataExtractor): ignore typedefs

Fixes #524
dart-archive · Feb 7, 2014 · 37f1c32 · 37f1c32
1 parent 73bf0d3
commit 37f1c32
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/core/registry.dart b/lib/core/registry.dart
@@ -70,6 +70,7 @@ abstract class AnnotationsMap<K> {
 @NgInjectableService()
 class MetadataExtractor {
   Iterable call(Type type) {
+    if (reflectType(type) is TypedefMirror) return [];
     var metadata = reflectClass(type).metadata;
     if (metadata == null) return [];
     return metadata.map((InstanceMirror im) => im.reflectee);

diff --git a/test/core/registry_spec.dart b/test/core/registry_spec.dart
@@ -30,8 +30,20 @@ main() => describe('RegistryMap', () {
     expect(keys).toEqual([new MyAnnotation('A'), new MyAnnotation('B')]);
     expect(types).toEqual([A1, A1]);
   });
+
+  it('should safely ignore typedefs', () {
+    var module = new Module()
+      ..type(MyMap)
+      ..type(MetadataExtractor)
+      ..value(MyTypedef, (String _) => null);
+
+    var injector = new DynamicInjector(modules: [module]);
+    expect(() => injector.get(MyMap), isNot(throws));
+  });
 });
 
+typedef void MyTypedef(String arg);
+
 class MyMap extends AnnotationMap<MyAnnotation> {
   MyMap(Injector injector, MetadataExtractor metadataExtractor)
       : super(injector, metadataExtractor);