fix(syntax): warnings in directive code

dart-archive · Nov 20, 2013 · 1f3e3f7 · 1f3e3f7
1 parent 201cbb5
commit 1f3e3f7
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/lib/core_dom/directive.dart b/lib/core_dom/directive.dart
@@ -75,10 +75,5 @@ String _snakeCase(String name, [separator = '_']) {
   _snakeReplace(Match match) {
     return (match.start != 0 ? separator : '') + match.group(0).toLowerCase();
   }
-  var x=  name.replaceAllMapped(_SNAKE_CASE_REGEXP, _snakeReplace);
-  if (x is String) return x;
-  throw [];
-  return x;
+  return name.replaceAllMapped(_SNAKE_CASE_REGEXP, _snakeReplace);
 }
-
-
diff --git a/lib/directive/ng_if.dart b/lib/directive/ng_if.dart
@@ -93,8 +93,12 @@ class NgIfDirective extends _NgUnlessIfAttrDirectiveBase {
                     BlockHole blockHole,
                     Scope scope): super(boundBlockFactory, blockHole, scope);
 
-  set condition(value) =>
-      (toBool(value) ? _ensureBlockExists() : _ensureBlockDestroyed());
+  set condition(value) {
+      if (toBool(value))
+        _ensureBlockExists();
+      else
+        _ensureBlockDestroyed();
+  }
 }
 
 
@@ -150,6 +154,10 @@ class NgUnlessDirective extends _NgUnlessIfAttrDirectiveBase {
                         BlockHole blockHole,
                         Scope scope): super(boundBlockFactory, blockHole, scope);
 
-  set condition(value) =>
-      (!toBool(value) ? _ensureBlockExists() : _ensureBlockDestroyed());
+  set condition(value) {
+    if (!toBool(value))
+      _ensureBlockExists();
+    else
+      _ensureBlockDestroyed();
+  }
 }