Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test files to config/ #566

Closed
9 tasks done
hansl opened this issue Apr 29, 2016 · 1 comment · Fixed by #567
Closed
9 tasks done

Move test files to config/ #566

hansl opened this issue Apr 29, 2016 · 1 comment · Fixed by #567
Assignees

Comments

@hansl
Copy link
Contributor

hansl commented Apr 29, 2016

The following files should be configurable and out of root:

  1. karma.conf.js
  2. protractor.conf.js
  3. karma-test-shim.js

TODO:

  • e2e:
    • Use the e2e.protractor.config to know the path to protractor.conf.js when running ng e2e.
    • The default value for e2e.protractor.config in new projects should be config/protractor.conf.js.
    • Move the protractor.conf.js file. This includes changing the path in the config to ...
  • Karma:
    • Use the test.karma.config to know the path to karma.conf.js when running ng e2e.
    • The default value for test.karma.config in new projects should be config/karma.conf.js.
    • Move the karma.conf.js file. This includes changing base path to ...
    • Move the shim to config. You need to include it in karma properly, but you don't need any other configuration.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant