Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular2, AoT compilation: Cannot determine the module for component AppComponent #3294

Closed
musahaidari opened this issue Nov 27, 2016 · 4 comments

Comments

@musahaidari
Copy link

OS?

Windows 7

Versions.

C:\Users\wdd>node --version
v6.6.0

Summary: I am trying to use Angular2 AoT for my Angular2 application, but since I have static providers to pass some values from server to Angular2, ngc shows some errors. My problem is how to get the ngFactory files created using ngc.

Details: I am using the cookbook guide, and running "node_modules/.bin/ngc" -p tsconfig-aot.json shows me the below error:

Error: Cannot determine the module for component AppComponent!
    at F:\workspace\node\my-project\node_modules\@angular\compiler\bundles\compiler.umd.js:12839:25
    at Array.map (native)
    at OfflineCompiler.compile (F:\workspace\node\my-project\node_modules\@angular\compiler\bundles\compiler.umd.js:12835:31)
    at F:\workspace\node\my-project\node_modules\@angular\compiler-cli\src\codegen.js:108:18
    at Array.map (native)
    at CodeGenerator.codegen (F:\workspace\node\my-project\node_modules\@angular\compiler-cli\src\codegen.js:106:38)
    at codegen (F:\workspace\node\my-project\node_modules\@angular\compiler-cli\src\main.js:7:81)
    at Object.main (F:\workspace\node\my-project\node_modules\@angular\tsc-wrapped\src\main.js:30:16)
    at Object.<anonymous> (F:\workspace\node\my-project\node_modules\@angular\compiler-cli\src\main.js:14:9)
    at Module._compile (module.js:541:32)
Compilation failed

tsconfig-aot.json:

{
  "compilerOptions": {
    "target": "es5",
    "module": "es2015",
    "moduleResolution": "node",
    "sourceMap": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "removeComments": false,
    "noImplicitAny": false
  },
  "exclude": [
    "node_modules",
    "typings"
  ],
  "angularCompilerOptions": {
    "genDir": "aot",
    "skipMetadataEmit" : true
 }
}

package.json:

{
  "name": "my-project",
  "version": "1.0.0",
  "scripts": {
    "postinstall": "typings install"
  },
  "license": "ISC",
  "dependencies": {
    "@angular/common": "~2.0.1",
    "@angular/compiler": "~2.0.1",
    "@angular/compiler-cli": "^0.6.0",
    "@angular/core": "~2.0.1",
    "@angular/forms": "~2.0.1",
    "@angular/http": "~2.0.1",
    "@angular/platform-browser": "~2.0.1",
    "@angular/platform-browser-dynamic": "~2.0.1",
    "@angular/platform-server": "^2.2.1",
    "@angular/router": "~3.0.1",
    "@angular/upgrade": "~2.0.1",
    "body-parser": "^1.15.2",
    "cookie-parser": "^1.4.3",
    "core-js": "^2.4.1",
    "crypto": "0.0.3",
    "express": "^4.14.0",
    "express-mysql-session": "^1.2.0",
    "express-session": "^1.14.1",
    "hammerjs": "^2.0.8",
    "reflect-metadata": "^0.1.8",
    "rxjs": "5.0.0-beta.12",
    "systemjs": "0.19.39",
    "zone.js": "^0.6.25",

    // Other dependancies


  },
  "devDependencies": {
    "concurrently": "^3.0.0",
    "typescript": "^2.0.3",
    "typings": "^1.4.0"
  }
}

index.pug:

html
    head
        base(href=config.baseUrl)
        title My title
        meta(charset='UTF-8')
        meta(name='viewport', content='width=device-width, initial-scale=1')
        link(rel='stylesheet', href="node_modules/ng2-toastr/bundles/ng2-toastr.min.css")
        link(rel='stylesheet', href='node_modules/ng2-material/ng2-material.css')
        link(rel='stylesheet', href='public/styles/index.css')
        script(src='node_modules/core-js/client/shim.min.js')
        script(src='node_modules/zone.js/dist/zone.js')
        script(src='node_modules/reflect-metadata/Reflect.js')
        script(src='node_modules/systemjs/dist/system.src.js')
        script(src='systemjs.config.js')
        script
            | System.import('app')
            |   .then(module => module.main(!{JSON.stringify(config)}), console.error.bind(console) );
    body
    tt-app My application, loading waiter application ...

main.ts:

/// <reference path="../../typings/index.d.ts" />


import {platformBrowserDynamic} from "@angular/platform-browser-dynamic";
import {createMainModule} from "./app.module";

export const main = (SERVER_CONFIG) => {
    platformBrowserDynamic().bootstrapModule(createMainModule(SERVER_CONFIG));
};

app.module.ts:

import {NgModule} from "@angular/core";
import {BrowserModule} from "@angular/platform-browser";
import {AppComponent} from "./app/app.component";
import {routing} from "./app.routing";
import {HttpModule} from "@angular/http";
import {AuthService} from "./auth.service";
import {ConfigService} from "./config.service";
import {CustomersModule} from "./customers/customers.module";

export const createMainModule = (SERVER_CONFIG) => {

    @NgModule({
        imports: [
            BrowserModule,
            routing,
            HttpModule,
        ],
        declarations: [AppComponent],
        providers: [
            AuthService,
            {
                provide: "SERVER_CONFIG",
                useValue: SERVER_CONFIG
            },
            ConfigService
        ],
        bootstrap: [AppComponent]
    })
    class AppModule {
    }
    return AppModule;
};

app.component.ts:

import {Component, OnInit} from "@angular/core";
import {ConfigService} from "../config.service";
import {AuthService} from "../auth.service";
import {Router} from "@angular/router";

@Component({
    selector: 'tt-app',
    templateUrl: 'partials/app/app.component'
})
export class AppComponent implements OnInit {

    user;

    constructor(private _configServer: ConfigService,
                private _authService: AuthService,
                private _router: Router) {
    }

    ngOnInit(): void {
        this.user = this._configServer.server.user;
    }

    logout() {
        this._authService
            .logout()
            .then((result)=> {
            })
            .catch((error)=> {
                this._router.navigate(['/login']);
            });
    }

}

Notes:

  • I verified that if I remove code for static provider, that I used for passing data from servver to Angular2, i.e. createMainModule() in app.module.ts, and so on, then ngc works fine.
  • I am using SystemJS as the module loader.
  • I have posted the same on stackoverflow incase there is already a technique I do not know about, but it seems that is not the case and passing data from server to client (with the method I have used) and AoT is not possible.
  • The method I have used to pass data from server to client is exactly used as explained in the official angular 2 docs, saying that, AoT should support it.
@tsabirgaliev
Copy link
Contributor

I had similar errors with lambdas. Converted them to ordinary functions, and errors gone.

@musahaidari
Copy link
Author

@tsabirgaliev I have lambdas too, but when I remove the static providers, then it compiles too, even with lambdas.

@filipesilva
Copy link
Contributor

This issue tracker is for issues related to angular-cli, not the AoT compiler in general. Stack overflow is the best bet for this sort of questions.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants