-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The minified release gives an error #692
Comments
Something may not be annotated... |
It happens when using ui-sref-active. See this plunk: http://plnkr.co/edit/XWOlRK |
That makes sense! I have added that recently. Any known fix? |
It looks like controller injection was not done correctly for $StateActiveDirective in line 1650: Currently: Should be: I'm new to ui-router, so cannot say for sure that my fix not introducing any new issues. But it solves minification issue and ui-sref-active directive looks working. |
Great! Thanks @ValLisetsky! |
Has a commit been made for this? |
Not sure actualy. #671 looks like it. |
Suck half day on it... wtf?? |
Would PR #725 fix this? |
Duplicate, see #671. |
me too, I have to tear down my app piece by piece to figure out which part is causing this, anyone have good idea about how to debug this kind of issue? Currently I learned that I should test my app in production mode ASAP |
When i use the unminified version everything works fine. But for the production version of my app i use the minified release v0.2.7.
As soon as i swap the unminified with the minified release i get this (unreadable) error:
I know the error means that it couldn't find a provider for dependency injection. But i have no idea which one because the file is minified. Maybe someone else has more insight in this?
It probably also has something to do with how i'm using the router because it doesn't happen at every state, but at some. Still its a ui-router bug because my code works when using the unminified release. I'm probably hitting a specific code path that has a bug/isn't minified correctly.
The text was updated successfully, but these errors were encountered: