-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat(tabs): add tabs grouping #160
Comments
Ok people, I've been very busy, but I've now got a working implementation running. Although it works, I'm not too happy about it. I got halfway to having the panes 'require' a '^?paneGroup', but I couldn't get the nesting working properly. I now solved the problem by having the tabs controller manually indexing the panes-per-panegroup. It works though. I will provide a pull request somewhere this week. |
How did you make the tabs into nab-pills? |
In the tabs template, simply replace the top class "nav-tabs" with "nav-pills". bootstrap.css will take care of the rest. |
👍 @bbottema This is beauty of native AngularJS directives with externalized templates! |
Sometimes I want tabs - so I will make a new pills template not replace the tabs one. I had downloaded the bundled templates js and didn't see any template files floating around Getting it now :) thanks! |
Hi guys, I created a new pull-request for this, pull 206. I've now provided two approaches to dropdown support in tabs and at the moment I can't invest more time than I already have, so you guys will have to figure out how to consolidate the various enhancements. Good luck, and I'll be watching for future releases. |
Bump. |
@pkozlowski-opensource I don't think this is mergeable anymore, as it's been 11 months. It however still is a nice feature. |
Based on discussion in #150
@petebacondarwin proposal seems to be really cool:
The text was updated successfully, but these errors were encountered: