Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat(tabs): add tabs grouping #160

Closed
pkozlowski-opensource opened this issue Feb 19, 2013 · 10 comments
Closed

feat(tabs): add tabs grouping #160

pkozlowski-opensource opened this issue Feb 19, 2013 · 10 comments

Comments

@pkozlowski-opensource
Copy link
Member

Based on discussion in #150

@petebacondarwin proposal seems to be really cool:

<tabs>
  <pane heading="Pane 1">Pane 1</pane>
  <pane-group heading="Group 1">
    <pane>Group 1 - Pane a</pane>
    <pane>Group 1 - Pane b</pane>
    <pane>Group 1 - Pane c</pane>
  </pane-group>
</tabs>
@bbottema
Copy link

bbottema commented Mar 4, 2013

Ok people, I've been very busy, but I've now got a working implementation running.

Although it works, I'm not too happy about it. I got halfway to having the panes 'require' a '^?paneGroup', but I couldn't get the nesting working properly. I now solved the problem by having the tabs controller manually indexing the panes-per-panegroup. It works though.

I will provide a pull request somewhere this week.

@bbottema
Copy link

bbottema commented Mar 4, 2013

And just for flavor here are the screenshots again



It looks pretty good with the nav-pills to:
dropdown-tabs-nav-pill

@petebacondarwin
Copy link
Member

Please take a look at the tabs rewrite that @ajoslin is doing before making this pull request: #186

@sanxac
Copy link

sanxac commented Mar 6, 2013

How did you make the tabs into nab-pills?

@bbottema
Copy link

bbottema commented Mar 6, 2013

In the tabs template, simply replace the top class "nav-tabs" with "nav-pills". bootstrap.css will take care of the rest.

@pkozlowski-opensource
Copy link
Member Author

👍 @bbottema This is beauty of native AngularJS directives with externalized templates!

@sanxac
Copy link

sanxac commented Mar 6, 2013

Sometimes I want tabs - so I will make a new pills template not replace the tabs one. I had downloaded the bundled templates js and didn't see any template files floating around

Getting it now :) thanks!

@bbottema
Copy link

bbottema commented Mar 9, 2013

Hi guys, I created a new pull-request for this, pull 206. I've now provided two approaches to dropdown support in tabs and at the moment I can't invest more time than I already have, so you guys will have to figure out how to consolidate the various enhancements.

Good luck, and I'll be watching for future releases.

@bbottema
Copy link

bbottema commented Jun 1, 2013

Bump.

@mvhecke
Copy link
Contributor

mvhecke commented Jan 19, 2014

@pkozlowski-opensource I don't think this is mergeable anymore, as it's been 11 months. It however still is a nice feature.

@chrisirhc chrisirhc added this to the Purgatory milestone Apr 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants