Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket fails in strict DI mode & stylus bootstrap import fails #2220

Open
1 task
syzer opened this issue Sep 10, 2016 · 6 comments
Open
1 task

Socket fails in strict DI mode & stylus bootstrap import fails #2220

syzer opened this issue Sep 10, 2016 · 6 comments

Comments

@syzer
Copy link

syzer commented Sep 10, 2016

  • I understand that GitHub issues are not for tech support, but for questions specific to this generator, bug reports, and feature requests.
Item Version
generator-angular-fullstack x.x.x
Node x.x.x
npm x.x.x
Operating System OS X 10 / Windows 10 / Ubuntu 15.10 / etc
etc etc
Item Answer
Transpiler Babel / TypeScript
Markup HTML / Pug
CSS CSS / LESS / SCSS / Stylus
Router ngRoute / ui-router
Client Tests Jasmine / Mocha
DB MongoDB / SQL
Auth Y / N
etc etc

Socket is not using explicit annotation and cannot be invoked in strict mode

@syzer
Copy link
Author

syzer commented Sep 10, 2016

also build fails if you pick stylus....
IMHO generator in version 4 is not usable

@syzer
Copy link
Author

syzer commented Sep 10, 2016

ERROR in ./~/css-loader!./~/stylus-loader!./client/app/app.styl
Module build failed: Error: ../node_modules/bootstrap-styl/bootstrap/index.styl:8:9
    4|  * Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
    5|  */
    6|
    7| // Core variables and mixins
    8| @import "bootstrap/variables"
--------------^
    9| @import "bootstrap/mixins"
   10|
   11| // Reset and dependencies

failed to locate @import file bootstrap/variables.styl

@syzer
Copy link
Author

syzer commented Sep 10, 2016

wasted 4 hours of my life...
stylus do not work
css works

but with ui.router
socket do not work!

strictDi: true => strictDi: false
fixes problem

@Koslun
Copy link
Member

Koslun commented Sep 11, 2016

If there is an actual issue it is imperative that you actually fill in what version and configuration you're using in detail. There are many issues fixed between even minor version changes.

You've hinted at the configuration that is likely relevant but always good to know exactly what you're using so someone else can replicate it perfectly. So edit this with your version and exact configurations you've tried.

Item | Version
----- | -----
generator-angular-fullstack | x.x.x
Node | x.x.x
npm | x.x.x
Operating System | OS X 10 / Windows 10 / Ubuntu 15.10 / etc
etc | etc

Item | Answer
----- | -----
Transpiler | Babel / TypeScript
Markup | HTML / Jade
CSS | CSS / LESS / SCSS / Stylus
Router | ngRoute / ui-router
Build Tool | Grunt / Gulp
Client Tests | Jasmine / Mocha
DB | MongoDB / SQL
Auth | Y / N
etc | etc

Taking it that you've found two different bugs so would ideally also be better to file two different issues.

Seems like the Stylus bug is "just" about fixing the bootstrap import. Might check that out myself.

Switching off strictDi is probably just a handy quick-fix for sockets so would have to check that out in more detail for a permanent fix.

@Koslun Koslun changed the title Build failed Socket fails in strict DI mode & stylus bootstrap import fails Sep 11, 2016
@Awk34
Copy link
Member

Awk34 commented Sep 13, 2016

See #2208 for socket service fix (merged 4 days before this issue was opened)

@syzer
Copy link
Author

syzer commented Sep 19, 2016

merged but probably not published :) ?

@Awk34 Awk34 added the V4 label Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants