Skip to content

Commit

Permalink
fix(gulp): build images before rev-replace
Browse files Browse the repository at this point in the history
When running `gulp build` the rev manifest will be remade, but the task
"build:client" which uses this file doesn't depend on "build:images"
which populates this file. The result is that when running `build`,
rev-replace will be unable to replace images as it doesn't wait for
images to be filled in.
Solution is to simply have "build:client" depend upon "build:images"
  • Loading branch information
azatoth committed Apr 21, 2016
1 parent e74acdd commit 4139694
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/templates/gulpfile.babel(gulp).js
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ gulp.task('build', cb => {

gulp.task('clean:dist', () => del([`${paths.dist}/!(.git*|.openshift|Procfile)**`], {dot: true}));

gulp.task('build:client', ['transpile:client', 'styles', 'html', 'constant'], () => {
gulp.task('build:client', ['transpile:client', 'styles', 'html', 'constant', 'build:images'], () => {
var manifest = gulp.src(`${paths.dist}/${clientPath}/assets/rev-manifest.json`);

var appFilter = plugins.filter('**/app.js', {restore: true});
Expand Down

0 comments on commit 4139694

Please sign in to comment.