Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): [component-selector] handle shadow dom components properly #559

Merged
merged 16 commits into from
Jul 13, 2021
Merged

feat(eslint-plugin): [component-selector] handle shadow dom components properly #559

merged 16 commits into from
Jul 13, 2021

Conversation

GavinWu1991
Copy link
Contributor

@GavinWu1991 GavinWu1991 commented Jun 29, 2021 •
edited
Loading

fix: #534

@GavinWu1991 GavinWu1991 marked this pull request as draft June 29, 2021 13:47
@nx-cloud
Copy link

nx-cloud bot commented Jun 29, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 8ba579b. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=check-configs --all --parallel
#000000 nx run-many --target=integration-test --all --withRegistry
#000000 nx run-many --target=test --all --parallel
#000000 nx run-many --target=typecheck --all --parallel

Sent with 💌 from NxCloud.

@GavinWu1991 GavinWu1991 marked this pull request as ready for review July 4, 2021 13:58
@codecov
Copy link

codecov bot commented Jul 4, 2021 •
edited
Loading

Codecov Report

Merging #559 (8ba579b) into master (149bf2f) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #559      +/-   ##
==========================================
+ Coverage   85.95%   86.00%   +0.05%     
==========================================
  Files          88       88              
  Lines        2363     2372       +9     
  Branches      409      412       +3     
==========================================
+ Hits         2031     2040       +9     
  Misses        195      195              
  Partials      137      137
Impacted Files Coverage Δ
...ages/eslint-plugin/src/rules/component-selector.ts 88.88% <100.00%> (+3.70%) ⬆️

rafaelss95
rafaelss95 reviewed Jul 4, 2021
View reviewed changes
Copy link
Member

@rafaelss95 rafaelss95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this, @GavinWu1991. I left some comments, let me know what you think.

packages/eslint-plugin/src/rules/component-selector.ts Outdated Show resolved Hide resolved
packages/eslint-plugin/docs/rules/component-selector.md Outdated Show resolved Hide resolved
packages/eslint-plugin/src/rules/component-selector.ts Outdated Show resolved Hide resolved
packages/eslint-plugin/tests/rules/component-selector.test.ts Outdated Show resolved Hide resolved
packages/eslint-plugin/tests/rules/component-selector.test.ts Outdated Show resolved Hide resolved
packages/eslint-plugin/tests/rules/component-selector.test.ts Outdated Show resolved Hide resolved
packages/eslint-plugin/tests/rules/component-selector.test.ts Outdated Show resolved Hide resolved
packages/eslint-plugin/tests/rules/component-selector.test.ts Outdated Show resolved Hide resolved
@rafaelss95 rafaelss95 changed the title feat(eslint-plugin): Rule [component-selector] handle shadow dom components properly feat(eslint-plugin): [component-selector] handle shadow dom components properly Jul 4, 2021
JamesHenry
JamesHenry requested changes Jul 10, 2021
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pending the implementation for of the dedicated error message

rafaelss95
rafaelss95 previously approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@rafaelss95 rafaelss95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks again :)

@GavinWu1991
Copy link
Contributor Author

LGTM! Thanks again :)

Thanks for your review, I feel like I learned something. :)

JamesHenry
JamesHenry approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GavinWu1991!

@JamesHenry JamesHenry merged commit ecbe684 into angular-eslint:master Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

@rafaelss95 rafaelss95 rafaelss95 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[component-selector] handle shadow dom components properly
3 participants
@GavinWu1991 @JamesHenry @rafaelss95