From 8b2cf0312dc5f41d1d3493a5cbcfa734cc4a5af9 Mon Sep 17 00:00:00 2001
From: Andrei Punko <andd3dfx@gmail.com>
Date: Sun, 3 Nov 2024 17:16:02 +0300
Subject: [PATCH] Organize POMs: move some repeatable stuff into parent POM

---
 crawler-engine/pom.xml     | 30 ++----------------------------
 pom.xml                    | 26 +++++++++++++++++++++++++-
 pravtor.ru-crawler/pom.xml | 26 +++-----------------------
 rabota.by-crawler/pom.xml  | 25 +------------------------
 4 files changed, 31 insertions(+), 76 deletions(-)

diff --git a/crawler-engine/pom.xml b/crawler-engine/pom.xml
index f262658..76dcb2f 100644
--- a/crawler-engine/pom.xml
+++ b/crawler-engine/pom.xml
@@ -11,25 +11,17 @@
 
     <artifactId>crawler-engine</artifactId>
 
-    <properties>
-        <maven.compiler.source>21</maven.compiler.source>
-        <maven.compiler.target>21</maven.compiler.target>
-        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-        <lombok.version>1.18.34</lombok.version>
-        <slf4j.version>2.0.10</slf4j.version>
-        <log4j-core.version>2.21.1</log4j-core.version>
-    </properties>
-
     <dependencies>
         <dependency>
             <groupId>org.projectlombok</groupId>
             <artifactId>lombok</artifactId>
             <version>${lombok.version}</version>
+            <scope>provided</scope>
         </dependency>
         <dependency>
             <groupId>org.jsoup</groupId>
             <artifactId>jsoup</artifactId>
-            <version>1.17.2</version>
+            <version>${jsoup.version}</version>
         </dependency>
 
         <!-- Logging -->
@@ -44,22 +36,4 @@
             <version>${slf4j.version}</version>
         </dependency>
     </dependencies>
-
-    <build>
-        <plugins>
-            <plugin>
-                <artifactId>maven-compiler-plugin</artifactId>
-                <version>3.13.0</version>
-                <configuration>
-                    <annotationProcessorPaths>
-                        <path>
-                            <groupId>org.projectlombok</groupId>
-                            <artifactId>lombok</artifactId>
-                            <version>${lombok.version}</version>
-                        </path>
-                    </annotationProcessorPaths>
-                </configuration>
-            </plugin>
-        </plugins>
-    </build>
 </project>
diff --git a/pom.xml b/pom.xml
index 95e43d1..eb146f2 100644
--- a/pom.xml
+++ b/pom.xml
@@ -13,9 +13,13 @@
   <properties>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
-
     <maven.compiler.source>21</maven.compiler.source>
     <maven.compiler.target>21</maven.compiler.target>
+
+    <lombok.version>1.18.34</lombok.version>
+    <jsoup.version>1.17.2</jsoup.version>
+    <slf4j.version>2.0.10</slf4j.version>
+    <log4j-core.version>2.21.1</log4j-core.version>
   </properties>
 
   <modules>
@@ -23,4 +27,24 @@
     <module>pravtor.ru-crawler</module>
     <module>rabota.by-crawler</module>
   </modules>
+
+  <build>
+    <pluginManagement>
+      <plugins>
+        <plugin>
+          <artifactId>maven-compiler-plugin</artifactId>
+          <version>3.13.0</version>
+          <configuration>
+            <annotationProcessorPaths>
+              <path>
+                <groupId>org.projectlombok</groupId>
+                <artifactId>lombok</artifactId>
+                <version>${lombok.version}</version>
+              </path>
+            </annotationProcessorPaths>
+          </configuration>
+        </plugin>
+      </plugins>
+    </pluginManagement>
+  </build>
 </project>
diff --git a/pravtor.ru-crawler/pom.xml b/pravtor.ru-crawler/pom.xml
index 3fff729..9ffb699 100644
--- a/pravtor.ru-crawler/pom.xml
+++ b/pravtor.ru-crawler/pom.xml
@@ -11,13 +11,6 @@
 
   <artifactId>pravtor.ru-crawler</artifactId>
 
-  <properties>
-    <apache-poi.version>5.2.5</apache-poi.version>
-    <lombok.version>1.18.30</lombok.version>
-    <slf4j.version>2.0.10</slf4j.version>
-    <log4j-core.version>2.21.1</log4j-core.version>
-  </properties>
-
   <dependencies>
     <dependency>
       <groupId>by.andd3dfx</groupId>
@@ -27,7 +20,7 @@
     <dependency>
       <groupId>org.jsoup</groupId>
       <artifactId>jsoup</artifactId>
-      <version>1.17.2</version>
+      <version>${jsoup.version}</version>
     </dependency>
     <dependency>
       <groupId>org.apache.commons</groupId>
@@ -43,13 +36,14 @@
     <dependency>
       <groupId>org.apache.poi</groupId>
       <artifactId>poi</artifactId>
-      <version>${apache-poi.version}</version>
+      <version>5.2.5</version>
     </dependency>
 
     <dependency>
       <groupId>org.projectlombok</groupId>
       <artifactId>lombok</artifactId>
       <version>${lombok.version}</version>
+      <scope>provided</scope>
     </dependency>
 
     <!-- Tests -->
@@ -122,20 +116,6 @@
           </execution>
         </executions>
       </plugin>
-
-      <plugin>
-        <artifactId>maven-compiler-plugin</artifactId>
-        <version>3.12.1</version>
-        <configuration>
-          <annotationProcessorPaths>
-            <path>
-              <groupId>org.projectlombok</groupId>
-              <artifactId>lombok</artifactId>
-              <version>${lombok.version}</version>
-            </path>
-          </annotationProcessorPaths>
-        </configuration>
-      </plugin>
     </plugins>
   </build>
 </project>
diff --git a/rabota.by-crawler/pom.xml b/rabota.by-crawler/pom.xml
index e9cc758..181aed3 100644
--- a/rabota.by-crawler/pom.xml
+++ b/rabota.by-crawler/pom.xml
@@ -11,11 +11,6 @@
 
   <artifactId>rabota.by-crawler</artifactId>
 
-  <properties>
-    <lombok.version>1.18.30</lombok.version>
-    <slf4j.version>1.7.36</slf4j.version>
-  </properties>
-
   <dependencies>
     <dependency>
       <groupId>by.andd3dfx</groupId>
@@ -30,7 +25,7 @@
     <dependency>
       <groupId>org.jsoup</groupId>
       <artifactId>jsoup</artifactId>
-      <version>1.14.3</version>
+      <version>${jsoup.version}</version>
     </dependency>
     <dependency>
       <groupId>org.projectlombok</groupId>
@@ -62,22 +57,4 @@
       <scope>test</scope>
     </dependency>
   </dependencies>
-
-  <build>
-    <plugins>
-      <plugin>
-        <artifactId>maven-compiler-plugin</artifactId>
-        <version>3.12.1</version>
-        <configuration>
-          <annotationProcessorPaths>
-            <path>
-              <groupId>org.projectlombok</groupId>
-              <artifactId>lombok</artifactId>
-              <version>${lombok.version}</version>
-            </path>
-          </annotationProcessorPaths>
-        </configuration>
-      </plugin>
-    </plugins>
-  </build>
 </project>
\ No newline at end of file