Skip to content
This repository was archived by the owner on Aug 27, 2022. It is now read-only.

[BUG]: Numbered images logic needs an update to prevent overriding existing images #291

Closed
andi34 opened this issue Aug 9, 2021 · 4 comments
Assignees
Labels
bug Something isn't working stale

Comments

@andi34
Copy link
Owner

andi34 commented Aug 9, 2021

Describe the bug
Currently we're counting the files inside the images folder or reading
database lenght to get the image name.
We are not really checking for the next available number which could
cause that we're loosing made images.

Example 1:
We have 3 images: 0001.jpg, 0002.jpg and 0003.jpg
Next image-name will be named 0004.jpg
Everything is fine here

Example 2:
We have 2 images: 0001.jpg and 0003.jpg
Next image-name will be named 0003.jpg!
This will override the already existing 0003.jpg!

@andi34 andi34 added the bug Something isn't working label Aug 9, 2021
@andi34 andi34 self-assigned this Sep 15, 2021
@andi34 andi34 changed the title [BUG] Numbered images logic needs an update to prevent overriding existing images [BUG]: Numbered images logic needs an update to prevent overriding existing images Oct 25, 2021
@stale
Copy link

stale bot commented Dec 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the stale label Dec 24, 2021
@andi34 andi34 removed the stale label Dec 27, 2021
@andi34
Copy link
Owner Author

andi34 commented Dec 27, 2021

Keep open

@stale
Copy link

stale bot commented Feb 26, 2022

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the stale label Feb 26, 2022
@stale
Copy link

stale bot commented Mar 12, 2022

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this as completed Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

1 participant