AAO Trace And Optimize will cause Poiyomi shader cant auto lock on

[lonelyicer]

AAO Version: 1.8.3
Poiyomi Version: 9.0.61, Pro 9.2.6

https://github.com/poiyomi/PoiyomiToonShader

No logs
Normally Poiyomi will auto-lock on Build, but using AAO will cause Poiyomi cant auto-lock.

[anatawa12]

Could you explain what shader lock on is, please?

I searched IVRCSDKPreprocessAvatarCallback on poiyomi and I see several callbacks registered and those are called after AAO so it might be incompatible with duplicating material for optimization in AAO.

[lonelyicer]

Poiyomi generates a unique shader variant on lock on, and only that variant will display correctly visual effect in VRChat.

Before Lock on:

After Lock on:

[lonelyicer]

Locked shaders are not editable, but are portable and can still display visual effects correctly without the correct Poiyomi shader installed.

[anatawa12]

Thank you for explanation.

I tried poiyomi 9.0.61 from VPM and I found that auto lock-on is working for AAO-duplicated materials.
And locked shader will automatically removed by NDMF (AAO) just after building avatar complete.
This is why you feel shader lock on does not work.

Even if there is some shader features requires shader lock on, I think it will work on uploaded avatar.
Please let me know if you have some features not working.

I found some change in behavior, but it's impossible to fix the change I think.
The difference is that shader lock on without AAO will affect material on Assets, but it with AAO won't affect material on Asset.
However, I think this is expected behavior (from AAO's perspective) because AAO will duplicate material, and Poiyomi will apply shader lock on after Poiyomi processes.
Because Avatar Optimizer is Non-Destructive tool, it's not allowed to edit material so we cannot avoid material duplication.
And there is no way to retrieve original material from duplicated one (except for API in NDMF) so this behavior change is impossible to fix I think.

Do you experienced something bad with this behavior difference?
If so could you explain that please?

[lonelyicer]

I found that AAO would remove some of my textures incorrectly even though I had locked Poiyomi manually, such as some masks and matcap, I'm not sure if it was a problem with other plugins, but the problem was fixed after I removed the AAO Trace And Optimizer component from Avatar ( The problem persisted after I turned off Merge Skinned Mesh and Optimize Texture)

[anatawa12]

Could you let me know the name of property or location of field in the inspector that texture was removed?

[lonelyicer]

_GlitterMask
_Matcap

[lonelyicer]

[anatawa12]

Thank you. I reproduced the problem with Glitter Mask.

[anatawa12]

Umm... After recompiling the AAO, I become could not reproduce the bug even if source code is exactly same as before....

[anatawa12]

Could you try upgrading / downgrading AAO and restarting Unity?

[lonelyicer]

I didn't do anything today, at most I ran it a couple of times after deleting the AAO T&O and the problem couldn't be reproduced