Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to fix/resolve flawfinder issues #441

Closed
rgetz opened this issue Apr 18, 2020 · 2 comments
Closed

need to fix/resolve flawfinder issues #441

rgetz opened this issue Apr 18, 2020 · 2 comments
Assignees
Milestone

Comments

@rgetz
Copy link
Contributor

rgetz commented Apr 18, 2020

Codacy reports:

image

We should work on this, and get it to a reasonable number before the next release.

Most of these are potential issues, not real issues (things like don't use strlen, because its bad), but there are lots of times it's OK in this code base, since we know all the strings are null terminated. However - if someone wanted to inject something into the library - it possible, and then the library would crash, so it still worth looking at...

@rgetz
Copy link
Contributor Author

rgetz commented Apr 23, 2020

Today was the first day we got to a rating of "A":

image

I'm mainly focusing on the C issues (C# issues should get resolved as part of #364) tagged as error or warning.
image image

@rgetz
Copy link
Contributor Author

rgetz commented Jun 4, 2020

All the major issues were resolved.

image

We still have some C warnings, but no errors, (one which needs to be dismissed as a false positive).
image

We still have alot of work to do on the C# bindings, but I think I will close this for now.

@rgetz rgetz closed this as completed Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant