Sizzle free #575
Closed
Sizzle free #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -666,7 +666,7 @@ function PickerConstructor( ELEMENT, NAME, COMPONENT, OPTIONS ) { | |||
| // prevent cases where focus is shifted onto external elements | |||
| // when using things like jQuery mobile or MagnificPopup (ref: #249 & #120). | |||
| // Also, for Firefox, don’t prevent action on the `option` element. | |||
| if ( event.type == 'mousedown' && !$( target ).is( ':input' ) && target.nodeName != 'OPTION' ) { | |||
| if ( event.type == 'mousedown' && !$( target ).is( 'input, select, textarea, button, option' )) { | |||
There was a problem hiding this comment.
@mmcgahan what about [contenteditable] or anything with a tabindex? We should probably add that in as well..?
There was a problem hiding this comment.
[contenteditable] might be a good option, although it's a little edge-case and might introduce awkward bugs - I would conservatively keep the constraint on standard :input targets for now (jQuery just does a tagName regex match for its :input pseudo-selector).
tabindex is probably redundant if we're matching on all other input-y things?
|
Merged into master: https://github.com/amsul/pickadate.js/ :) Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:inputis only available with jQuery builds that use Sizzle. Using an equivalent CSS selector string (input, select, textarea, button) makes pickadate compatible with more codebases.This particular update only adds 1 character to lib/picker.js while simplifying an event target test in
prepareElementRoot()