-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #22 to add pooling support #23
Conversation
deployment/src/main/java/org/amqphub/quarkus/qpid/jms/deployment/QpidJmsProcessor.java
Outdated
Show resolved
Hide resolved
runtime/src/main/java/org/amqphub/quarkus/qpid/jms/QpidJmsRecorder.java
Outdated
Show resolved
Hide resolved
runtime/src/main/java/org/amqphub/quarkus/qpid/jms/runtime/ConnectionFactoryWrapper.java
Show resolved
Hide resolved
deployment/src/main/java/org/amqphub/quarkus/qpid/jms/deployment/QpidJmsProcessor.java
Outdated
Show resolved
Hide resolved
runtime/src/main/java/org/amqphub/quarkus/qpid/jms/runtime/QpidJmsProducer.java
Outdated
Show resolved
Hide resolved
5eb4a33
to
724174b
Compare
724174b
to
5410b28
Compare
I looked it over and it seems good. I was originally planning to do a release and update before Quarkus Platform 3.0.0 but I'll hold off for now, as I decided to give it a try and immediately hit a couple of issues with using quarkus-pooled-jms, one a trivial warning from erroneously registering the Artemis JMS CF for reflection, and the other a more significant native build failure: |
Thanks a lot and I will take a look at these two issues in |
@gemmellr I just fixed these two issues and can you check it again? if all of them work, I will start to do a new release of |
I tried them out and they looked to work, but I didnt particularly like having all the jta deps when not using them so I put together an alternative in quarkiverse/quarkus-pooled-jms#113 |
@gemmellr I've merged your PR. |
Released in Quarkus Qpid JMS 2.1.0 (using Qpid JMS 2.2.0) and Quarkus Qpid JMS 0.43.0 (using Qpid JMS 1.8.0) extension releases. |
With these changes,
quarkus-qpid-jms
could leverage the pooling capability provided by quarkus-pooled-jms by combineing these two extensions simply.