Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #22 to add pooling support #23

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

zhfeng
Copy link
Contributor

@zhfeng zhfeng commented Apr 19, 2023

With these changes, quarkus-qpid-jms could leverage the pooling capability provided by quarkus-pooled-jms by combineing these two extensions simply.

@zhfeng zhfeng force-pushed the issue_22_support_pooling branch from 5eb4a33 to 724174b Compare April 20, 2023 03:47
@zhfeng zhfeng force-pushed the issue_22_support_pooling branch from 724174b to 5410b28 Compare April 24, 2023 03:09
@zhfeng zhfeng requested a review from gemmellr April 24, 2023 03:10
@gemmellr
Copy link
Collaborator

I looked it over and it seems good. I was originally planning to do a release and update before Quarkus Platform 3.0.0 but I'll hold off for now, as I decided to give it a try and immediately hit a couple of issues with using quarkus-pooled-jms, one a trivial warning from erroneously registering the Artemis JMS CF for reflection, and the other a more significant native build failure:

@zhfeng
Copy link
Contributor Author

zhfeng commented Apr 24, 2023

Thanks a lot and I will take a look at these two issues in quarkus-pooled-jms.

@zhfeng
Copy link
Contributor Author

zhfeng commented Apr 25, 2023

@gemmellr I just fixed these two issues and can you check it again? if all of them work, I will start to do a new release of quarkus-pooled-jms soon.

@gemmellr
Copy link
Collaborator

I tried them out and they looked to work, but I didnt particularly like having all the jta deps when not using them so I put together an alternative in quarkiverse/quarkus-pooled-jms#113

@zhfeng
Copy link
Contributor Author

zhfeng commented Apr 26, 2023

@gemmellr I've merged your PR.

@gemmellr gemmellr merged commit 5410b28 into amqphub:main Apr 26, 2023
gemmellr added a commit that referenced this pull request Apr 26, 2023
gemmellr added a commit that referenced this pull request Apr 26, 2023
@gemmellr
Copy link
Collaborator

Released in Quarkus Qpid JMS 2.1.0 (using Qpid JMS 2.2.0) and Quarkus Qpid JMS 0.43.0 (using Qpid JMS 1.8.0) extension releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants