Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

Automatically update the validator #97

Closed
ithinkihaveacat opened this issue Jan 4, 2019 · 2 comments · Fixed by #122
Closed

Automatically update the validator #97

ithinkihaveacat opened this issue Jan 4, 2019 · 2 comments · Fixed by #122

Comments

@ithinkihaveacat
Copy link
Collaborator

Currently, the validator version needs to be updated manually by hitting a magic URL. This causes various problems, including slowly drifting out of date. This should be changed so that the validator is never older than, say, 7 days old.
@ithinkihaveacat ithinkihaveacat mentioned this issue Jan 4, 2019
Closed
@ithinkihaveacat
Copy link
Collaborator Author

Another problem, which I think was happened with #110, is that there are be multiple front-end servers, and the magic URL only updates on of them (randomly).

@ithinkihaveacat ithinkihaveacat mentioned this issue Mar 21, 2019
Closed
@ithinkihaveacat ithinkihaveacat mentioned this issue May 9, 2019
Closed
@ithinkihaveacat
Copy link
Collaborator Author

See also the related amp-toolbox issue ampproject/amp-toolbox#378.

@ithinkihaveacat ithinkihaveacat mentioned this issue Aug 2, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Auto update validator ithinkihaveacat/ampbench
1 participant
@ithinkihaveacat