Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete accessibility issues #3301

Closed
spacedmonkey opened this issue Sep 19, 2019 · 0 comments · Fixed by #3294
Closed

Autocomplete accessibility issues #3301

spacedmonkey opened this issue Sep 19, 2019 · 0 comments · Fixed by #3294
Assignees
Labels
Accessibility Changes that impact accessibility and need corresponding review (e.g. markup changes). Bug Something isn't working
Milestone

Comments

@spacedmonkey
Copy link
Contributor

spacedmonkey commented Sep 19, 2019

When running the automated accessibility tests in #3294 the follow errors where found with the autocomplete component.

  Rule: "aria-input-field-name" (ARIA input fields have an accessible name)
    Help: https://dequeuniversity.com/rules/axe/3.3/aria-input-field-name?application=axe-puppeteer
    Affected Nodes:
      #amp-stories-font-family-picker-1__listbox
        Fix ANY of the following:
        - aria-label attribute does not exist or is empty
        - aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
        - Element has no title attribute or the title attribute is empty
    Rule: "aria-required-children" (Certain ARIA roles must contain particular children)
    Help: https://dequeuniversity.com/rules/axe/3.3/aria-required-children?application=axe-puppeteer
    Affected Nodes:
      #amp-stories-font-family-picker-1__listbox
        Fix ANY of the following:
        - Required ARIA child role not present: option
   Rule: "aria-valid-attr-value" (ARIA attributes must conform to valid values)
    Help: https://dequeuniversity.com/rules/axe/3.3/aria-valid-attr-value?application=axe-puppeteer
    Affected Nodes:
      #amp-stories-font-family-picker-3
        Fix ALL of the following:
          - Invalid ARIA attribute value: aria-activedescendant="false".
    Rule: "listitem" (<li> elements must be contained in a <ul> or <ol>)
    Help: https://dequeuniversity.com/rules/axe/3.3/listitem?application=axe-puppeteer
    Affected Nodes:
      .autocomplete__option
        Fix ANY of the following:
        - List item does not have a <ul>, <ol> or role="list" parent element
@spacedmonkey spacedmonkey added Bug Something isn't working AMP Stories Accessibility Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Sep 19, 2019
@spacedmonkey spacedmonkey self-assigned this Sep 19, 2019
@westonruter westonruter modified the milestones: v1.3.1, v1.3 Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Changes that impact accessibility and need corresponding review (e.g. markup changes). Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants