From 54316f719cdfb8a31118bab7d0b578043e7f71f2 Mon Sep 17 00:00:00 2001 From: afc163 Date: Mon, 4 Sep 2023 17:58:51 +0800 Subject: [PATCH] test: disable timeout for puppeteer waitForSelector (#44611) --- package.json | 3 +-- tests/shared/imageTest.tsx | 8 ++++++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index bf4b91bb945c..a5223894ab90 100644 --- a/package.json +++ b/package.json @@ -194,11 +194,9 @@ "@types/jest-image-snapshot": "^6.1.0", "@types/jquery": "^3.5.14", "@types/lodash": "^4.14.139", - "@types/lz-string": "^1.3.34", "@types/node": "^20.0.0", "@types/prismjs": "^1.26.0", "@types/progress": "^2.0.5", - "@types/puppeteer": "^7.0.4", "@types/qs": "^6.9.7", "@types/react": "^18.0.0", "@types/react-copy-to-clipboard": "^5.0.0", @@ -272,6 +270,7 @@ "pretty-format": "^29.0.0", "prismjs": "^1.29.0", "progress": "^2.0.3", + "puppeteer": "^21.1.1", "qs": "^6.10.1", "rc-footer": "^0.6.8", "rc-tween-one": "^3.0.3", diff --git a/tests/shared/imageTest.tsx b/tests/shared/imageTest.tsx index 372e1a18fed6..ab723470fd65 100644 --- a/tests/shared/imageTest.tsx +++ b/tests/shared/imageTest.tsx @@ -75,16 +75,20 @@ export default function imageTest(component: React.ReactElement) { styleStr, ); - await page.waitForSelector('#end-of-screen'); + await page.waitForSelector('#end-of-screen', { + timeout: 0, + }); const image = await page.screenshot({ fullPage: true, + captureBeyondViewport: true, + optimizeForSpeed: true, }); expect(image).toMatchImageSnapshot(); MockDate.reset(); - page.removeListener('request', onRequestHandle); + page.off('request', onRequestHandle); }); }