Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comma added on last entry of JSON export makes result not valid JSON #842

Closed
2 tasks done
jbrendel opened this issue Oct 23, 2024 · 1 comment
Closed
2 tasks done

Comma added on last entry of JSON export makes result not valid JSON #842

jbrendel opened this issue Oct 23, 2024 · 1 comment

Comments

@jbrendel
Copy link
Contributor

Checklist

  • The bug is reproducible against the latest release or master.
  • There are no similar issues or pull requests to fix it yet.

Describe the bug

Export a table with more than one entry. The last one will have a trailing ,, which is not valid JSON.

Steps to reproduce the bug

Export a table, check the last two characters, they will be ,].

Expected behavior

No trailing ,

Actual behavior

A comma is added after the last entry in the output table.

Debugging material

No response

Environment

Ubuntu 20.04, version 0.20.0

Additional context

I'll provide a PR for the fix shortly.
@jbrendel jbrendel mentioned this issue Oct 23, 2024
Merged
@jbrendel
Copy link
Contributor Author

I have submitted a PR for this: #843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbrendel @aminalaee