Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distill l-gutter not working #227

Closed
3 tasks done
vmasrani opened this issue Mar 28, 2021 · 3 comments
Closed
3 tasks done

Distill l-gutter not working #227

vmasrani opened this issue Mar 28, 2021 · 3 comments

Comments

@vmasrani
Copy link

vmasrani commented Mar 28, 2021

Acknowledge the following

  • I carefully read and followed the Getting Started guide.
  • I read through FAQ and searched through the past issues, none of which addressed my issue.
  • The issue I am raising is a potential bug in al-folio and not just a usage question.
    [For usage questions, please use gitter chat instead of raising an issue.]

Describe the bug
Longer text within the l-gutter div causes weird spacing as seen in the screenshot below:

Screen Shot 2021-03-27 at 10 31 40 PM

To Reproduce
I modified the text at the bottom of 2018-12-22-distill.md to:


The final layout is for marginalia, asides, and footnotes.
It does not interrupt the normal flow of `.l-body` sized text except on mobile screen sizes.

<div class="fake-img l-gutter">
  <p>.l-gutter .l-gutter .l-gutter .l-gutter .l-gutter .l-gutter .l-gutter .l-gutter .l-gutter .l-gutter .l-gutter .l-gutter .l-gutter .l-gutter .l-gutter .l-gutter .l-gutter .l-gutter .l-gutter .l-gutter </p>
</div>

The final layout is for marginalia, asides, and footnotes.
It does not interrupt the normal flow of `.l-body` sized text except on mobile screen sizes.

The final layout is for marginalia, asides, and footnotes.
It does not interrupt the normal flow of `.l-body` sized text except on mobile screen sizes.

and this produced the screenshot above

Expected behavior
The gutter text doesn't add whitespace to the body

System (please complete the following information):

  • OS: macOS Catalina
  • Browser (and its version) Edge: 89.0.774.63
  • Jekyll version: 3.9.0
  • Ruby version: 2.6.5
@alshedivat
Copy link
Owner

This issue is coming from distill.pub's template.v2.js. I can reproduce the behavior by directly editing the styles of one of their articles that uses v2 template (see the screenshot below). I recommend raising this issue directly in distilpub/template.

Screen Shot 2021-03-29 at 12 59 56 PM

@vmasrani
Copy link
Author

Great will do - thanks!

@stale
Copy link

stale bot commented May 29, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 29, 2021
@stale stale bot closed this as completed Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants