Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimum PHP version in composer.json is incorrect #6

Closed
IMSoP opened this issue Apr 10, 2022 · 2 comments
Closed

Minimum PHP version in composer.json is incorrect #6

IMSoP opened this issue Apr 10, 2022 · 2 comments

Comments

@IMSoP
Copy link
Contributor

IMSoP commented Apr 10, 2022

Currently, the composer.json lists a minimum PHP version of 5.6, but the actual code includes many features which require later versions, such as a type declaration of ?string, which is only valid since PHP 7.1

Either the documented minimum version should be updated, or the code changed to run on older versions.
@IMSoP
Copy link
Contributor Author

IMSoP commented Apr 10, 2022

By the way, thanks for making this repo, and I love the use of Basque as a test locale!

@alphp
Copy link
Owner

alphp commented Apr 10, 2022

Thanks a lot

@alphp alphp closed this as completed Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IMSoP @alphp