Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server-side search #286

Open
phil-s opened this issue Jul 31, 2024 · 1 comment
Open

Server-side search #286

phil-s opened this issue Jul 31, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@phil-s
Copy link

phil-s commented Jul 31, 2024

It would be nice to have support for server-side search in Ement.el.

@alphapapa​ commented in chat:

What's needed is support for the events API so that when we show a message from a search result we can show the surrounding context.

(The Event Context provided with each result (if requested) contains those surrounding events_before and events_after.)

@alphapapa
Copy link
Owner

alphapapa commented Jul 31, 2024

Yeah, that much could be done quickly. What I meant to say is that we need to be able to jump to an arbitrary event in a room and then go forward/back in the timeline, loading other events as needed, and possibly integrating them with the timeline we already have for the room. If the search feature were limited to just seeing the matching event and a few on either side of it, it would feel very limiting. So we need more comprehensive support for the events API, integrating it with existing functionality (that would also facilitate bookmarking events in rooms and then jumping back to them).

And similarly to how the matrix-js-sdk maintains and joins together multiple timelines for a room, we might need to implement something like that (otherwise we would probably end up dumping old events into the timeline with recent events, and possibly having to sort the whole list of events periodically, which could be a performance issue); i.e. we might need some kind of API that abstracts over a room's timeline that may have arbitrary gaps.

@alphapapa alphapapa self-assigned this Jul 31, 2024
@alphapapa alphapapa added enhancement New feature or request help wanted Extra attention is needed labels Jul 31, 2024
@alphapapa alphapapa added this to the Future milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants