Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Send device_id and initial_device_display_name on login #134

Closed
viiru- opened this issue Mar 17, 2023 · 1 comment
Closed

[FR] Send device_id and initial_device_display_name on login #134

viiru- opened this issue Mar 17, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@viiru-
Copy link
Contributor

viiru- commented Mar 17, 2023

Sending a stable device_id would make it possible to do automatic server-side session management (see https://spec.matrix.org/v1.3/client-server-api/#relationship-between-access-tokens-and-devices). I'd recommend a one-way hash of something like Ement-<username>@<hostname>.

The initial_device_display_name is meant to be human readable and make it easy to manually terminate sessions on devices that no longer exist and so on. It should perhaps be customizable. I'd use something similar as the default (include the string "Ement" and the username and hostname).

(note that I'm actively not submitting PRs that would just get stuck while waiting for the FSF paperwork, if that clears I will probably work on this myself unless someone else beats me to it)

@alphapapa
Copy link
Owner

Thanks for bringing this to my attention. Definitely want to do this. :)

@alphapapa alphapapa self-assigned this Mar 17, 2023
@alphapapa alphapapa added the enhancement New feature or request label Mar 17, 2023
@alphapapa alphapapa added this to the 0.8 milestone Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants