Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reported a11y issue: Some code examples use a colour that has very low contrast with the background colour #213

Closed
richardTowers opened this issue Mar 4, 2021 · 3 comments

Comments

@richardTowers
Copy link
Contributor

This was reported in a recent accessibility audit

I'm not 100% it's true though. Looking at all the highlight colours in the stylesheet with:

<pre class="highlight ruby"><code><span class="cs">cs</span>	<span class="kr">kr</span>	<span class="kn">kn</span>	<span class="kt">kt</span>
<span class="ow">ow</span>	<span class="py">py</span>	<span class="nn">nn</span>	<span class="nf">nf</span>	<span class="vi">vi</span>
<span class="nd">nd</span>	<span class="nx">nx</span>	<span class="ne">ne</span>	<span class="l">l</span>	<span class="ld">ld</span>
<span class="mo">mo</span>	<span class="sh">sh</span>	<span class="ss">ss</span>	<span class="si">si</span>	<span class="sd">sd</span>
<span class="sc">sc</span>	<span class="gi">gi</span>	<span class="gd">gd</span>	<span class="p">p</span>	<span class="w">w</span>
<span class="hll">hll</span>	<span class="gt">gt</span>	<span class="gs">gs</span>	<span class="ge">ge</span>	<span class="gh">gh</span>
<span class="gu">gu</span>	<span class="gp">gp</span></code></pre>

Renders as:

image

Firefox's Accessibility tools report that all of these are at least AA compliant, so I'm not sure this is a real issue.

I'm raising it here as a better place for discussion than a spreadsheet. If we don't think it's reproducible then we can probably close it and cross it off our list of issues.

@jonathanglassman
Copy link
Contributor

@selfthinker can you advise?

@36degrees
Copy link
Contributor

36degrees commented Mar 4, 2021

When was the audit done / what version of the gem was it against?

Is there any chance it was resolved by #189? Looks like it shipped in v2.0.13.

@richardTowers
Copy link
Contributor Author

Possibly. The audit was done in August, which is just a little bit after that shipped. I can't find a reference to this in the original report, so I'm inclined to think it's not a real issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants