Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust padding on the panel component for new typography scale #3897

Closed
Tracked by #2289
owenatgov opened this issue Jul 3, 2023 · 0 comments · Fixed by #4152
Closed
Tracked by #2289

Adjust padding on the panel component for new typography scale #3897

owenatgov opened this issue Jul 3, 2023 · 0 comments · Fixed by #4152
Assignees
@owenatgov
Labels
panel typography

Comments

@owenatgov
Copy link
Contributor

What

Adjust the padding on the panel component from 10px (2 on the spacing scale) to 15px (3).

Should be merged into #2421 and not main.

Why

During testing of the govuk-frontend components against the new typography scale, we noticed that the panel component now looked quite squashed on small screens with the text no longer dropping down to a smaller size on small screens.

Who needs to work on this

Developers

Who needs to review this

Developers, designers
@owenatgov owenatgov added this to the v5.x-candidate milestone Jul 3, 2023
This was referenced Jul 3, 2023
Open
Closed
@kellylee-gds kellylee-gds moved this from Backlog 🗄 to Sprint Backlog 🏃🏼‍♀️ in GOV.UK Design System cycle board Jul 26, 2023
@owenatgov owenatgov changed the title New typography scale: Adjust padding on the panel component Adjust padding on the panel component for new typography scale Aug 14, 2023
@owenatgov owenatgov self-assigned this Aug 30, 2023
@owenatgov owenatgov moved this from Sprint Backlog 🏃🏼‍♀️ to In progress 📝 in GOV.UK Design System cycle board Aug 31, 2023
@owenatgov owenatgov mentioned this issue Aug 31, 2023
Merged
@owenatgov owenatgov moved this from In progress 📝 to Needs review 🔍 in GOV.UK Design System cycle board Aug 31, 2023
@owenatgov owenatgov linked a pull request Aug 31, 2023 that will close this issue
Increase panel padding on small screens #4152
Merged
@owenatgov owenatgov moved this from Needs review 🔍 to Done 🏁 in GOV.UK Design System cycle board Aug 31, 2023
@owenatgov owenatgov removed this from the v5.x-candidate milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owenatgov owenatgov

Labels
panel typography
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase panel padding on small screens alphagov/govuk-frontend
1 participant
@owenatgov