Change layout of footer #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the footer to simplify the content and reduce the amount of empty space. Changes are based on designs by @NoraGDS and @aliuk2012.
We want our footer to look more like the footer from GOV.UK and GOV.UK Deisgn System, so we can swap the components on an app by app basis in the future. This commit moves the text "Built by GDS" to a separate line, similar to how it is styled in alphagov/digitalmarketplace-govuk-frontend.
|
Looks awesome. Guessing this is a major version bump/changelog situation? |
Oh yes, thanks for reminding me |
lfdebrux
force-pushed
the
ldeb-update-footer-to-two-column-layout
branch
from
30668d8 to
6b54aed
Compare
Added |
aliuk2012
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://trello.com/c/lXpy2vZH/142-3-change-footer-to-use-two-column-layout-in-digitalmarketplace-frontend-toolkit-and-all-frontend-apps
We want our footer to look more like the footer from GOV.UK and GOV.UK Deisgn System, so we can swap the components on an app by app basis in the future. We also wanted to simplify the content in the footer, and reduce the number of columns.
This PR changes the layout of our existing footer so to achieve these aims. The changes made were put together by @NoraGDS and @aliuk2012; there's more details on the ticket above.
Unfortunately there isn't an easy way to preview the changes as adding a footer page to the frontend toolkit preview app didn't work very well, but I will attach some screenshots below.
Screenshots
Homepage with new footer
Before and after