Follow up questions #304
Follow up questions #304
Conversation
allait
force-pushed
the
follow-up-questions
branch
from
7bd0aac to
3ce51eb
Compare
allait
force-pushed
the
follow-up-questions
branch
from
3ce51eb to
c464e03
Compare
|
@samuelhwilliams added hidden flag for list-entry questions |
| followup: requirement-evidence-110 | ||
| followup: | ||
| true: | ||
| - requirement-evidence-110 |
There was a problem hiding this comment.
This should be the other way around, shouldn't it?
followup:
requirement-evidence-110:
- true
There was a problem hiding this comment.
This is not YAML format used by the content loader, it's the data we'd normally pass into toolkit form macros, so this is what .values_followup would return, which is a reversed mapping.
`hidden` question property should only ever be set to `True` if present (since the only thing it controls is whether the question should be initially hidden), so we can remove the separate `if hidden is defined` check, which would cause issues with Nunjucks.
Merges the boolean and radio question form templates into one and adds support for the multiple followup questions using the new `Question.values_followup` property passed in as `followup`.
…#383 We have to ship the file separately until the GOV.UK frontend toolkit PR is merged.
allait
force-pushed
the
follow-up-questions
branch
from
c464e03 to
ed4984f
Compare
Also updates `followup` format in page examples
allait
force-pushed
the
follow-up-questions
branch
from
ed4984f to
5172528
Compare
allait
force-pushed
the
follow-up-questions
branch
from
5172528 to
74eada6
Compare
| @@ -13,7 +13,7 @@ | |||
| {% elif message %} | |||
| <div class="message-wrapper"> | |||
| {% endif %} | |||
| <fieldset class="question {% if first_question %}first-question{% endif %}" id="{{ id }}"> | |||
| <fieldset class="question {% if first_question %}first-question{% endif %}{% if hidden %} js-hidden related-information{% endif %}" id="{{ id }}"> | |||
There was a problem hiding this comment.
This is a thing we've done in a few places where we add extra spaces to classnames.
If you remove the space after class="question and put it before first-question, it's more correct.
| {% endif %} | ||
|
|
||
| {% for option in options %} | ||
| {% set input_value = option.value if 'value' in option else option.label %} |
There was a problem hiding this comment.
Good call fixing this stuff. I know @benvand was asking about it.
|
I think go for it. 👍 There's some crappy grey borders in there, but we can patch that in the next couple days, I think. |
Remove 'is defined' check from textbox form template
hiddenquestion property should only ever be set toTrueif present(since the only thing it controls is whether the question should be
initially hidden), so we can remove the separate
if hidden is definedcheck, which would cause issues with Nunjucks.
Add followup support for radio and checkbox questions
Merges the boolean and radio question form templates into one and
adds support for the multiple followup questions using the new
Question.values_followupproperty passed in asfollowup.