WIP: Discussion: Separate default and GOV.UK styles #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related: #285 |
|
This would be useful for me, as I’d like to use this on a project I’m working on, but I’m having to override a lot of the default styling. |
aliuk2012
changed the title
aliuk2012
changed the title
aliuk2012
changed the title
This was referenced Sep 11, 2019
|
Theming would also be useful for several NHS services that I know of. Interested to see this progress. |
|
Think this is a good suggestion but closing for now since Dave has left GDS |
|
I merely left the building |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going to do a PR to update the input style from GOV.UK Elements to GOV.UK Frontend but when looking at the multiple uses of this component form an open source perspective I thought it could be useful to break the styles up into "Default", a version of the autocomplete with basic brand-free styling with separate overrides for "GOV.UK Frontend" styles.
There may be a better way to achieve this technically, but I've done the PR as a proof of concept / idea.
Default / generic styles
GOV.UK overrides (Updated to GOV.UK Frontend size / padding / responsive text)