[Feature] Receipt trait in alloy-consensus

[prestwich]

• Update trait TxReceipt in alloy-consensus
• fn status in trait Receipt
• Receipt bound on type Recept in trait Network
• impl Receipt for ReceiptEnvelope and related types
• change status function on rpc receipt type to delegate to Receipt implementation of inner
• impl<T: Receipt> Receipt for ReceiptResponse

Originally posted by @prestwich in #456 (comment)

[developeruche]

@prestwich can you give more context to;

Receipt bound on type Recept in trait Network

and

impl<T: Receipt> Receipt for ReceiptResponse

[zilayo]

seems related so leaving here instead of a new issue.

Current UX for accessing logs from a WithOtherFields<TransactionReceipt<AnyReceiptEnvelope<Log>>> receipt is:

receipt.inner.inner.inner.receipt.logs

Currently there are only implementations for AnyReceiptEnvelope<()> - these need to be exposed for AnyReceiptEnvelope<T> as well.

alloy/crates/consensus/src/receipt/any.rs

Lines 18 to 27 in cd5e0f7

	pub struct AnyReceiptEnvelope<T = Log> {
	/// The receipt envelope.
	#[cfg_attr(feature = "serde", serde(flatten))]
	pub inner: ReceiptWithBloom<T>,
	/// The transaction type.
	#[cfg_attr(feature = "serde", serde(with = "alloy_serde::num::u8_hex"))]
	pub r#type: u8,
	}
	impl AnyReceiptEnvelope {

Note - there's already a TxReceipt trait that has fn success which is equivalent to what fn status would be.

Perhaps makes sense to remove this trait altogether in favor of the Receipt trait mentioned above?

[prestwich]

Note - there's already a TxReceipt trait that has fn success which is equivalent to what fn status would be.

Yeah, i think my issue here isn't "create a Receipt trait" it's "ensure that the existing Receipt trait is properly implemented for relevant types further up the abstraction stack, like ReceiptResponse and AnyReceiptEnvelope, and used in abstracted code like the Provider and PendingTransaction

[prestwich]

Current UX for accessing logs from a WithOtherFields<TransactionReceipt<AnyReceiptEnvelope<Log>>> receipt is:

receipt.inner.inner.inner.receipt.logs

Currently there are only implementations for AnyReceiptEnvelope<()> - these need to be exposed for AnyReceiptEnvelope<T> as well.

This is the sort of UX problem that a consistenyl applied and used Receipt trait would solve 👍

[developeruche]

Note - there's already a TxReceipt trait that has fn success which is equivalent to what fn status would be.

Yeah, i think my issue here isn't "create a Receipt trait" it's "ensure that the existing Receipt trait is properly implemented for relevant types further up the abstraction stack, like ReceiptResponse and AnyReceiptEnvelope, and used in abstracted code like the Provider and PendingTransaction

Oh yeah... got it