-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add AnyNetwork
#383
feat: add AnyNetwork
#383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also remove the catch all fields currently present on some of the rpc-types, e.g.
alloy/crates/rpc-types/src/eth/block.rs
Lines 962 to 963 in 28cab90
#[serde(flatten)] | |
pub extra_info: BTreeMap<String, serde_json::Value>, |
alloy/crates/rpc-types/src/eth/transaction/request.rs
Lines 55 to 57 in 28cab90
/// Support for arbitrary additional fields. | |
#[serde(flatten)] | |
pub other: OtherFields, |
alloy/crates/rpc-types/src/eth/transaction/receipt.rs
Lines 56 to 58 in 28cab90
/// Arbitrary extra fields. | |
#[serde(flatten)] | |
pub other: OtherFields, |
Not sure if this should be removed: alloy/crates/rpc-types/src/eth/block.rs Lines 962 to 963 in 28cab90
as Edit: Looks like |
@leruaa Makes sense, pls flag in that issue that we need to make the proper adjustments it for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, with a followup issue to add tests with various networks' receipt types in #424
The PR shows a requested change from @mattsse, but I marked all conversations as resolved. Is this a bug? |
not a bug, change requests live until the reviewer or an admin dismisses it. cc @mattsse Im cool with merge when you are |
Closes #81