-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] eip7251 has incorrect consolidation predeploy code #1103
Comments
This was referenced Jul 25, 2024
Yes, this was my bad. I opened up a draft PR to remind myself to correctly trim it, which I will do within the next hour. Unfortunately the devex is super bad for these kind of EIPs, because they don't post the runtime bytecode, only the deployment bytecode, so you manually need to trim it -.- |
Manually verifying:
Verified on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
the leading
0x0f5f395ff
needs to be trimmed to match spec in which the code starts withsender push20
which is0x3373
. The current bytecode seems to be some sort of manual trimming error on the deployment tx code?https://github.com/alloy-rs/alloy/blob/2ce8525d016f3fa9dc9c5a61afe44126a479243f/crates/eips/src/eip7251.rs#L14C66-L14C732
The text was updated successfully, but these errors were encountered: