Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme specification for captions not used in ggplot2 examples #82

Open
mine-cetinkaya-rundel opened this issue Mar 30, 2021 · 2 comments

Comments

@mine-cetinkaya-rundel
Copy link

In the ggplot2 examples there are some theme specifications for captions, e.g.

plot.caption = element_text(hjust = 0, face= "italic"),
plot.caption.position = "plot"

I believe these are not used since the plots don't have captions. Were they supposed to have captions or should these be removed? I'm happy to send in a PR but I wasn't sure which way to go. 🐧

@allisonhorst
Copy link
Owner

Haha yeah that does imply that we intended to add captions at some point, thank you Mine! I think we should add captions to all of the images & figures. I really need to refresh the package based on this and a few other PRs, I'll add it to the to-do list w/plans to do some housekeeping in the next couple of weeks.

@koliharesh
Copy link

Hello Sir/Madam, I would like to contribute in your project to solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants