Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add footer with link to usage #163

Merged
merged 24 commits into from
Sep 28, 2022
Merged

feat: add footer with link to usage #163

merged 24 commits into from
Sep 28, 2022

Conversation

jakebolam
Copy link
Collaborator

@jakebolam jakebolam commented Feb 7, 2019 •
edited
Loading

@jakebolam jakebolam changed the title WIP feat: add footer WIP feat: add footer with link to usage Feb 7, 2019
Berkmann18
Berkmann18 reviewed Feb 8, 2019
View reviewed changes
Berkmann18
Berkmann18 reviewed Feb 8, 2019
View reviewed changes
Berkmann18 pushed a commit that referenced this pull request May 24, 2020
@jakebolam
Revert "fix(Analytics): log user correctly (#162)" (#163)
97d35c8 
This reverts commit 2f73945.
@Berkmann18
Copy link
Member

@jakebolam Are you still planning on working on this?

@tenshiAMD tenshiAMD mentioned this pull request Sep 6, 2022
Merged
4 tasks
@tenshiAMD
Merge remote-tracking branch 'origin/master' into feat/style-table
6744c99 
* origin/master: (85 commits)
  refactor: log full error stack on error (#316)
  chore: fix status badges (#315)
  docs: add JoshuaKGoldberg as a contributor for bug (#314)
  fix: incorrect usage of `tbody` (#311)
  fix: trim `nextLink` before slicing (#309)
  fix: set default value as `7` for `contributorsPerLine` (#139)
  chore(deps): bump dependencies and devDeps (#298)
  refactor: add tbody to contributors table (#307)
  docs: add Lucas-C as a contributor for doc (#306)
  fix: scriptName + improving usage messages (#305)
  docs: add vapurrmaid as a contributor (#304)
  chore(deps): CVE-2021-23337 in inquirer->lodash (#303)
  docs: add SirWindfield as a contributor (#297)
  feat: add namespaced token (#296)
  docs: add LaChapeliere as a contributor (#292)
  feat(contribution-types): add research contribution type (#291)
  docs: add darekkay as a contributor (#290)
  feat: display a meaningful error when the config file is missing (#288)
  docs: add melink14 as a contributor (#285)
  docs: add jdalrymple as a contributor (#264)
  ...
@tenshiAMD
cleanups
ba83147
tenshiAMD
tenshiAMD requested changes Sep 13, 2022
View reviewed changes
Copy link
Member

@tenshiAMD tenshiAMD left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO:

  • Add tests

@tenshiAMD tenshiAMD self-assigned this Sep 13, 2022
@tenshiAMD tenshiAMD changed the title WIP feat: add footer with link to usage feat: add footer with link to usage Sep 13, 2022
@tenshiAMD tenshiAMD changed the title feat: add footer with link to usage WIP feat: add footer with link to usage Sep 13, 2022
@tenshiAMD
Copy link
Member

tenshiAMD commented Sep 13, 2022 •
edited
Loading

@gr2m @Berkmann18 can I ask for your help? can you check what's wrong with the tests? I cannot see what's wrong with the snapshots based on the logs. Thanks! 🎉

@tenshiAMD tenshiAMD changed the title WIP feat: add footer with link to usage feat: add footer with link to usage Sep 13, 2022
@tenshiAMD
Copy link
Member

@gr2m please check what's wrong with the tests. I have no idea what's the issue. 😕

@tenshiAMD
Copy link
Member

@gr2m please check what's wrong with the tests. I have no idea what's the issue. 😕

@gr2m that's weird. all tests are passing now. 😄

@tenshiAMD
Copy link
Member

tenshiAMD commented Sep 27, 2022 •
edited
Loading

@Berkmann18 @gr2m please review. let me know what are your thoughts. Here's a preview. https://github.com/all-contributors/cli/blob/feat/style-table/README.md

gr2m
gr2m reviewed Sep 27, 2022
View reviewed changes
.all-contributorsrc
@@ -5,6 +5,7 @@
"repoType": "github",
"commit": false,
"contributorsPerLine": 6,
"linkToUsage": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we document this new option in the README?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gr2m all done all-contributors/all-contributors#646 🚀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gr2m anything else we missed?

@gr2m gr2m merged commit b41e668 into master Sep 28, 2022
@gr2m gr2m deleted the feat/style-table branch September 28, 2022 16:54
@tenshiAMD tenshiAMD mentioned this pull request Sep 28, 2022
Closed
@tenshiAMD
Copy link
Member

@all-contributors please add @tenshiAMD for test

@allcontributors allcontributors bot mentioned this pull request Sep 28, 2022
Merged
@allcontributors
Copy link
Contributor

@tenshiAMD

I've put up a pull request to add @tenshiAMD! 🎉

@all-contributors-release-bot
Copy link
Member

🎉 This PR is included in version 6.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Mhmonicox Mhmonicox mentioned this pull request May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m left review comments

@tenshiAMD tenshiAMD tenshiAMD approved these changes

@Berkmann18 Berkmann18 Awaiting requested review from Berkmann18

Assignees

@tenshiAMD tenshiAMD

Labels
enhancement pinned released status: in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakebolam @Berkmann18 @tenshiAMD @all-contributors-release-bot @gr2m