From b5b02dec7242a0d47dd8fa54e2bfc9849059b8fe Mon Sep 17 00:00:00 2001 From: C C Magnus Gustavsson Date: Fri, 24 May 2024 12:18:53 +0200 Subject: [PATCH] Don't ignore IPv6 addresses when a single network interface is specified (#1979) Don't ignore IPv6 addresses when a single network interface is specified SUMMARY When "ipv6_adresses" are used with "network" without specifying "interfaces", the parameter is ignored and no IPv6 adresses get set. I don't believe this is the intended or correct behaviour. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Reviewed-by: Helen Bailey Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis --- changelogs/fragments/1979-do-not-ignore-ipv6-addresses.yaml | 3 +++ plugins/modules/ec2_instance.py | 3 +++ 2 files changed, 6 insertions(+) create mode 100644 changelogs/fragments/1979-do-not-ignore-ipv6-addresses.yaml diff --git a/changelogs/fragments/1979-do-not-ignore-ipv6-addresses.yaml b/changelogs/fragments/1979-do-not-ignore-ipv6-addresses.yaml new file mode 100644 index 00000000000..95ada6d654d --- /dev/null +++ b/changelogs/fragments/1979-do-not-ignore-ipv6-addresses.yaml @@ -0,0 +1,3 @@ +--- +bugfixes: + - ec2_instance - do not ignore IPv6 addresses when a single network interface is specified (https://github.com/ansible-collections/amazon.aws/pull/1979). diff --git a/plugins/modules/ec2_instance.py b/plugins/modules/ec2_instance.py index ce64750c378..b853dc544d5 100644 --- a/plugins/modules/ec2_instance.py +++ b/plugins/modules/ec2_instance.py @@ -1339,6 +1339,9 @@ def build_network_spec(params): sub = get_default_subnet(default_vpc, availability_zone=module.params.get("availability_zone")) spec["SubnetId"] = sub["SubnetId"] + if network.get("ipv6_addresses"): + spec["Ipv6Addresses"] = [{"Ipv6Address": a} for a in network.get("ipv6_addresses", [])] + if network.get("private_ip_address"): spec["PrivateIpAddress"] = network["private_ip_address"]