Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting more accurate results in 2018.1 vs 2019.1 #495

Closed
barefoots opened this issue Jun 6, 2019 · 7 comments · Fixed by alicevision/AliceVision#646
Closed

Getting more accurate results in 2018.1 vs 2019.1 #495

barefoots opened this issue Jun 6, 2019 · 7 comments · Fixed by alicevision/AliceVision#646

Comments

@barefoots
Copy link

barefoots commented Jun 6, 2019

Hello Alicevision Team,

Thankyou for all your hard work on such a fantastic piece of software! Thankyou for fixing the bug related to retexturing a reimported mesh with new uvs.

The problem i am running into is related to the SfM point cloud reconstruction.
In Meshroom 2018.1 I threw in photos from my Motorola G4 Plus mobile phone and the results were great & accurate, without any tweaking.

In 2019.1 the same photos produce a very different result. The point cloud looks to be sucked in towards the middle. Outlying objects are close and on top of each other. The depth calculations are not accurate. The final model looks smooshed around in places, or completely different when compared to results from 2018.1.

I am wondering what has changed between the versions to have such different outcomes?
And more importantly, what do I need to do to get the kind of results I was getting from 2018.1 without having settings that greatly increase the processing time?

Attached are screen captures of the SfM from each version of Meshroom using the same photo sets & default settings for all nodes.

2018.1. - Point Cloud (Cloud is spread out accurately accordingly to reality)
2018_1_
.
Textured Mesh Result
2018_1_model_

2019.1. - Point Cloud (Cloud is sucked in closer to centre. Squished together)
2019 1_

Could not get a final textured model from this photo set. Depth Map would crash at first chunk.

.
Example 2.
2018.1 - Textured Mesh (Tree Trunk)
2018 1_tree_

2019.1 - Textured Mesh (Tree Trunk)
2019 1_tree_

Thanks in advance for your help and thank-you again for all your hard work.
Kind Regards,
Brendan

@natowi
Copy link
Member

natowi commented Jun 6, 2019

I´ve read about this problem before (here on github or in the google group). When I remember correctly there were some changes introduced in the 2019.1 release that led to different results/behaviours for the same dataset compared to the 2018.1 release.
The 2019.2 release is around the corner which includes improvements and bug fixes.

@fabiencastan
Copy link
Member

@barefoots Thanks for your precise report. I'm quite surprised by your results.
Have your done these 2 reconstructions with the default parameters?
Could you share your dataset to see if we can reproduce it?

@natowi
Copy link
Member

natowi commented Jun 6, 2019

Something changed between 2018.1 and 2019.1.
This are the SfM landmarks of one of my datasets (default parameters):
Dataset in 2018.1: landmarks: 24570
Dataset in 2019.1: landmarks: 31685
In this case I get more landmarks in the 2019.1 release, but I also can remember getting fewer landmarks for some datasets. e.g. this dataset:

2018

2019

same dataset with random image names:
2018.1: landmarks: 18004
2019.1: landmarks: 17916

@fabiencastan
Copy link
Member

The choice of the initial image pair may change from one run to another. In that case, you can start the reconstruction from a very different part of the scene which may provide very different results.

This problem is independent from the release version, you can recompute the same dataset with the same version and get different results. On most datasets the output will be almost the same but on some datasets were there are multiple candidates for the initial pair with similar scores, you may start from a very different place and get very different results.

The question is therefore to know, if the issue reported here comes from this problem or if there is really a difference between the 2 releases.

And in the long run, of course, improve the repeatability of the initial pair choice which is already somewhere in the todo list.

@barefoots
Copy link
Author

barefoots commented Jun 6, 2019

Hey guys,

Thanks for your quick responses.
I am happy to provide a link to my photos via this dropbox link. [Here]

There are 3 sets of photos.
Both the images for the above examples and a extra set of a cliff I tried today.
I have included screen shots of the cliff mesh from both versions in the photo folder.
Also in the Tree folder I have provided screen shots of each nodes attributes from both 2018 & 2019. I know you don't need to see each node but put them in anyway.

Hope it helps.
Thanks again.

Kind Regards,
Brendan

@yann-lty
Copy link
Member

yann-lty commented Jun 7, 2019

It seems that something went wrong with the sensor database for this specific camera model between 2018.1 and 2019.1.

Metadata from images
Make: Motorola
Model: Moto G (4)

2018.1 cameraSensors.db
Motorola;Moto G (4);6.06 => used value (correct)
2019.1 cameraSensors.db
Motorola;Moto G;6.06
Motorola;Motorola 4;6.06;
Motorola;Motorola Moto G4;3.67;devicespecifications => used value (not correct)
Motorola;Motorola Moto G4 Plus;6.06;devicespecifications

If you open the database file and replace one of the first 2 lines with - or add -
Motorola;Moto G (4);6.06
and re-create a project with your images it should fix your problem.
You can access the sensor database file from Meshroom:
image
See the wiki page for more details.
Let us know if this works for you, we'll fix that for the next release!

@barefoots
Copy link
Author

@fabiencastan @yann-lty
Hey guys,

Thanks! The correction to the device specification worked beautifully!!

Thank-you so much for checking it out for me and figure out what was going wrong! I have re-run the previous data sets and some others done in the 2018 release....they have come out better and faster than before! So cool, even though they are photos from a budget phone.

I look forward to seeing how you continue to improve & update this excellent software.
Thanks again,
Kind regards,
Brendan

Screenshot_1
Screenshot_4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants