Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports canary routing with multiple values for one query param #39

Closed
lianglli opened this issue Aug 4, 2023 · 1 comment · Fixed by #72
Closed

Supports canary routing with multiple values for one query param #39

lianglli opened this issue Aug 4, 2023 · 1 comment · Fixed by #72
Labels
enhancement New feature or request
Milestone

Comments

@lianglli
Copy link
Member

lianglli commented Aug 4, 2023

No description provided.

@lianglli lianglli added the enhancement New feature or request label Aug 4, 2023
@lianglli lianglli added this to the 1.0.1 milestone Aug 4, 2023
@lianglli lianglli changed the title Supports canary routing of nginx.ingress.kubernetes.io/canary-by-query-value with multiple values for one query param Supports canary routing of with multiple values for one query param Aug 4, 2023
@lianglli lianglli changed the title Supports canary routing of with multiple values for one query param Supports canary routing with multiple values for one query param Aug 4, 2023
@lianglli
Copy link
Member Author

lianglli commented Nov 1, 2023

apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  annotations:
    nginx.ingress.kubernetes.io/canary: "true"
    nginx.ingress.kubernetes.io/canary-by-query: open3
    nginx.ingress.kubernetes.io/canary-by-query-value: abc1||abc2||abc3||abc4||abc5||abc6||abc7||abc8||abc9||abc10||abc11||abc12||abc13||abc14||abc15||abc16||abc17||abc18||abc19||abc20||abc21
    nginx.ingress.kubernetes.io/ssl-redirect: "true"
  creationTimestamp: "2023-10-31T06:30:31Z"
  generation: 2
  name: tengine-ingress-hello-query-ing
  namespace: default
  resourceVersion: "28152616"
  uid: debebfd0-afd2-4604-af8d-a41ad400bfbc
spec:
  ingressClassName: opensource-ingress
  rules:
  - host: echo.w1.com
    http:
      paths:
      - backend:
          service:
            name: tengine-ingress-hello3-service
            port:
              number: 80
        path: /
        pathType: Prefix
  tls:
  - hosts:
    - echo.w1.com
    secretName: https-server-1
status:
  loadBalancer:
    ingress:
    - {}

默认configmap 配置,"max-canary-query-val-num"允许路由匹配的query参数值个数是20,用户可以通过cm配置按需调整。

	// Max number of query value for canary annotation 'canary-by-query-value'
	MaxCanaryQueryValNum int `json:"max-canary-query-val-num"`

MaxCanaryQueryValNum:         20,

............................................................

$ curl -i -k https://echo.w1.com/?open3=abc20
HTTP/2 301 
server: Tengine/3.1.0
date: Wed, 01 Nov 2023 08:56:10 GMT
location: /?open3=abc20/
strict-transport-security: max-age=0
ups-target-key: default-tengine-ingress-hello3-service-80
x-protocol: HTTP/2.0
alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant