Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the code of nacos discovery example and add comments. #2931

Closed
Phixsura opened this issue Nov 27, 2022 · 2 comments · Fixed by #2933
Closed

Optimize the code of nacos discovery example and add comments. #2931

Phixsura opened this issue Nov 27, 2022 · 2 comments · Fixed by #2933

Comments

@Phixsura
Copy link
Contributor

I found that there is still system output in the example code of Nacos discovery example, and I hope it can be optimized to log output. At the same time, I hope I can optimize the code specification and add comments to the code for reading.
@steverao
Copy link
Collaborator

We are welcome you to create a PR to optimize it.

@Phixsura Phixsura mentioned this issue Nov 28, 2022
Merged
@Phixsura
Copy link
Contributor Author

I think this document also needs to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor/nacos-discovery-example
2 participants
@steverao @Phixsura