Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follower's state machine ignore read request. #7952

Closed
horizonzy opened this issue Mar 17, 2022 · 6 comments
Closed

Follower's state machine ignore read request. #7952

horizonzy opened this issue Mar 17, 2022 · 6 comments
Labels
area/Nacos Core kind/enhancement Category issues or prs related to enhancement.

Comments

@horizonzy
Copy link
Collaborator

Expected behavior
when follower read index failed, it will redirect to leader by raft-log read, then the raft-log will be copy to all nodes(include follower), follower will apply read raft-log also. In fact, follower can ignore read raft-log.

@horizonzy horizonzy added kind/enhancement Category issues or prs related to enhancement. help wanted Extra attention is needed good first issue Good for newcomers labels Mar 17, 2022
@Mikecarbon
Copy link

Expected behavior when follower read index failed, it will redirect to leader by raft-log read, then the raft-log will be copy to all nodes(include follower), follower will apply read raft-log also. In fact, follower can ignore read raft-log.

Expected behavior when follower read index failed, it will redirect to leader by raft-log read, then the raft-log will be copy to all nodes(include follower), follower will apply read raft-log also. In fact, follower can ignore read raft-log.
Writer don't follow read raft log.

@Westside991
Copy link

Main

@KomachiSion KomachiSion added status/need discuss and removed good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement. labels Mar 23, 2022
@KomachiSion
Copy link
Collaborator

I think the problem is caused by jraft system, is it?

@horizonzy
Copy link
Collaborator Author

It's nacos state machine logic, it can be enhance. @chuntaojun cc

@chuntaojun
Copy link
Collaborator

It's nacos state machine logic, it can be enhance. @chuntaojun cc

yes. it's can be optimize, if read operation throuth raft log not read-index, follower not need apply

@KomachiSion
Copy link
Collaborator

@horizonzy do some enhancement and submit PR?

@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. area/Nacos Core and removed help wanted Extra attention is needed status/need discuss labels Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos Core kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

No branches or pull requests

5 participants