-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.7.6版本 reset、refreshDeps 会被重置为defaultParams[0].current,不符合业务需求 #2172
Comments
相关 MR: #2090 |
那如果 |
我赞同这个说法,不要重复定义 pageSize,否则会产生歧义,默认优先级 defaultParams 中高一些 |
@Ali-ovo 但是要兼容之前的版本,以前的版本是以 defaultPageSize 为准,你这边改的以 defaultParams 为准了,是个 break change,这个在 3.x 版本先不这么改,我先 revert 回去了,后续在 v4 再做调整哈 |
好的没问题 |
已经修复发新版了,v3.3.7 |
这个版本修复修出bug了。
![image](https://user-images.githubusercontent.com/32298068/233951239-19c24ca5-bc02-4944-857c-fa542a2e3a27.png)
如果reset要充值页码,应该用reset defaultPageSize, 而不是defaultParams,defaultParams是作为初次传参使用的。不然的话,refreshDeps的说明是refreshDeps 变化,会重置 current 到第一页,并重新发起请求。现在这个版本,会把current重置到defaultParams的current.
希望尽快修复!!!! @sorrycc
The text was updated successfully, but these errors were encountered: