Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first run shipjs prepare in ci fails with don't understandable error #561

Closed
jeetiss opened this issue Dec 25, 2019 · 5 comments
Closed

Comments

@jeetiss
Copy link
Contributor

jeetiss commented Dec 25, 2019

Describe the bug
First run shipjs prepare --yes fails with strange error!
https://github.com/globis-org/frontend-standard/commit/75174cf562831a93f205e35eb0fcc56baa986adf/checks?check_suite_id=373443031#step:6:40

I think will be better if we write something like: "you need run shipjs prepare manually first time"

To Reproduce
Steps to reproduce the behavior:

  1. install shipjs with github actions
  2. run manual prepare from actions
  3. shipjs fails

Expected behavior
shipjs fails with clear message

@jeetiss jeetiss changed the title first run shipjs prepare in ci fails with don't understandable first run shipjs prepare in ci fails with don't understandable error Dec 25, 2019
@eunjae-lee
Copy link
Contributor

eunjae-lee commented Dec 26, 2019

Oh okay. The prompt pops up because of the missing tag.

I think

  1. When --yes is given and git tag is missing l, we should throw an error instead of asking to choose commits. Because when attaching --yes, people expect no prompt.

  2. We add an option to prepare command.

shipjs prepare --commit-from 75174c
  1. When --yes is given and tag is missing, we throw an error and tell user to add --commit-from option. We should show example commands for both normal command line and github actions.

  2. And we should modify our github actions so that user can do something like

@shipjs preprare --commit-from 75174c

What do you think?

(btw, to be clear, I'm going to work on this. Just asking for opinions here)

@jeetiss
Copy link
Contributor Author

jeetiss commented Dec 28, 2019

1-3 points sound legit for me, but I not sure about 4! How can we provide option to github actions through issues comment? Is it possible?)

@eunjae-lee
Copy link
Contributor

1-3 points sound legit for me, but I not sure about 4! How can we provide option to github actions through issues comment? Is it possible?)

We might be able to comment a list of recent 10-20 commits and let user choose?
But even if so, user has to leave another comment including the commit hash.
Then it just sounds like @shipjs preprare --commit-from 75174c.

Any idea?

@eunjae-lee
Copy link
Contributor

eunjae-lee commented Dec 29, 2019

1 & 3. #570
2. #572
4. ?

@eunjae-lee
Copy link
Contributor

Not sure about 4, and I don't even know how to do it.
Last time I tried it but couldn't find any way to manipulate content of github issue comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants