fix: print error message when hub doesn't exist (#205)

algolia · Aug 21, 2019 · 9ba45ff · 9ba45ff
1 parent ebb3e78
commit 9ba45ff
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/GUIDE.md b/GUIDE.md
@@ -59,7 +59,7 @@ github.com:
 
 You can get an access token from [here](https://github.com/settings/tokens).
 
-Or you can simply run `hub api` and it will generate the token and write the config file for you.
+Or you can simply run `hub api`, follow the instruction and it will generate the token and write the config file for you.
 
 ### Dry Mode
 

diff --git a/packages/shipjs/src/step/checkHub.js b/packages/shipjs/src/step/checkHub.js
@@ -7,10 +7,13 @@ export default () =>
       title: 'Checking if `hub` exists.',
     },
     ({ print, error, exitProcess }) => {
-      const exists = silentExec('hub --version').code === 0;
+      const exists =
+        silentExec('hub --version', { ignoreError: true }).code === 0;
       if (!exists) {
         print(error('You need to install `hub` first.'));
-        print('  > https://github.com/github/hub#installation');
+        print(
+          '  > https://github.com/algolia/shipjs/blob/master/GUIDE.md#install-hub'
+        );
         exitProcess(1);
       }
     }