fix(refinementList): cap maxFacetHits to 100 for SFFV
#4523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cap the `maxFacetHits` value to 100 because the Algolia API doesn't support a greater number. See https://www.algolia.com/doc/api-reference/api-parameters/maxFacetHits/ Closes #4521.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8c5a7a4:
|
|
seems to work fine! |
eunjae-lee
suggested changes
Sep 24, 2020
|
@eunjae-lee I see that the dev bundlesize threshold was decreased. We originally put a high arbitrary number because it's counter productive to track the dev bundle size. It leads us to going for poorer DX. I increased it back to a higher number than needed. |
eunjae-lee
approved these changes
Sep 24, 2020
francoischalifour
changed the title
maxFacetHits to 100maxFacetHits to 100 for SFFV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cap the
maxFacetHitsvalue to 100 because the Algolia API doesn't support a greater number.An Enterprise customer has faced this issue in Vue InstantSearch and it's challenging to fix user-land.
Closes #4521.