fix(typescript): export correct types #4476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes some miscellaneous typescript issues discovered in angular instantsearch - if JS client v3 is used, it's imperative that the ts-ignore comments stay present, since not the same exports are used. Solution is to double-annotate to keep the multi-line version in exposed to the d.ts (see e.g. microsoft/TypeScript#39520) - similar in places.js - when updating TypeScript, I found that api-extractor can't deal with `import()` types, so those have to be transformed - fix stricter behaviour of tranformItems in hitsPerPage (we send the user the "render" values, not the one they entered) - SpeechRecognitionError is no longer exported in lib.d.ts, and is a generic Event now - updated Typescript to 3.8.3. I've tried 3.9.2 as well, but that has a bug with `function()` (transforms to `(arg:any) => ;` instead of `(arg:any) => any;`). I didn't open a TS issue for it, since it's fixed in v4 which we can migrate to later
Haroenv
commented
Aug 14, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9c009e1:
|
yannickcr
suggested changes
Aug 14, 2020
|
At least in the playground code like this was working in v4, but not 3.9: /**
* @param {function()} arg0
*/
function(arg0) {}I couldn’t find an issue for it though, but since it’s fixed, there must have been one |
yannickcr
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes some miscellaneous typescript issues discovered in angular instantsearch
Result
importline microsoft/TypeScript#39520)import()types, so those have to be transformedfunction()(transforms to(arg:any) => ;instead of(arg:any) => any;). I didn't open a TS issue for it, since it's fixed in v4 which we can migrate to later